-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text: Explain investigations #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
9c779b8
to
56768a8
Compare
I added a commit that decouples tweaking from the core of SimplPedPop first. I found this conceptually easier, and easier to describe and implement. This has the potential to create some merge conflicts due to the renames, but they should be easy to resolve... |
56768a8
to
b1dd2fd
Compare
I had not implemented this version because my aim was to not add any computational overhead in the happy path except what is absolutely necessary for Taproot tweaking. Your version adds an extra group addition. This may count as a downside, even just from the conceptually perspective. But I can see how your version is simpler to understand and to describe. I'm fine either way. |
Oh, I missed that. Fixed in 8ef8bc7. (The idea is that this is an optimization that can be explained in a code comment and doesn't need to be mentioned in the text.) |
Nice! I still think the simplpedpop internals description needs an update now. |
No description provided.