Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: Explain investigations #74

Merged
merged 2 commits into from
Dec 18, 2024
Merged

text: Explain investigations #74

merged 2 commits into from
Dec 18, 2024

Conversation

real-or-random
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

README.md Outdated Show resolved Hide resolved
@real-or-random real-or-random changed the title simplpedpop: Explain blame internals text: Explain investigations Dec 18, 2024
@real-or-random real-or-random marked this pull request as ready for review December 18, 2024 16:42
@real-or-random
Copy link
Collaborator Author

I added a commit that decouples tweaking from the core of SimplPedPop first. I found this conceptually easier, and easier to describe and implement. This has the potential to create some merge conflicts due to the renames, but they should be easy to resolve...

@jonasnick
Copy link
Collaborator

I found this conceptually easier, and easier to describe and implement.

I had not implemented this version because my aim was to not add any computational overhead in the happy path except what is absolutely necessary for Taproot tweaking. Your version adds an extra group addition. This may count as a downside, even just from the conceptually perspective. But I can see how your version is simpler to understand and to describe. I'm fine either way.

@jonasnick jonasnick merged commit 7146486 into master Dec 18, 2024
2 checks passed
@real-or-random
Copy link
Collaborator Author

real-or-random commented Dec 18, 2024

Your version adds an extra group addition.

Oh, I missed that. Fixed in 8ef8bc7. (The idea is that this is an optimization that can be explained in a code comment and doesn't need to be mentioned in the text.)

@jonasnick
Copy link
Collaborator

Nice! I still think the simplpedpop internals description needs an update now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants