Fetch MetaMask Code in XDCPay #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear unapproved transactions from txStateManager.transactions on createNewVaultAndRestore
The state snapshot that was attached to Sentry errors was removed recently in MetaMask#8794 because it had become too large. The snapshot has now been restored and reduced in size. A utility function has been written to reduce the state object to just the requested properties. This seemed safer than filtering out state that is known to be large or to contain identifiable information. This is not a great solution, as now knowledge about the state shape resides in this large constant, but it will suffice for now. I am hopeful that we can decorate our controllers with this metadata in the future instead, as part of the upcoming background controller refactor. A separate `getSentryState` global function has been added to get the reduced state, so that the old `getCleanAppState` function that we used to use could remain unchanged. It's still useful to get that full state copy while debugging, and in e2e tests.
* Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Mark Stacey <[email protected]> Co-authored-by: Mark Stacey <[email protected]>
Adds design system colors to the css/variables/colors file and deprecates old colors in the deprecated itcss/variables folder
Version v8.0.5 RC
See [`array-callback-return`](https://eslint.org/docs/rules/array-callback-return) for more information. This change enables `array-callback-return` and fixes the issues raised by the rule.
Sync `master` with `develop`
…return Fix array-callback-return issues
See [`callback-return`](https://eslint.org/docs/rules/callback-return) for more information. This change enables `callback-return` and fixes the resulting issues.
…#9030) Wallet accounts can't be deleted from the contact list. This button never worked, nor should it.
The `extra` property of errors sent to Sentry is sometimes not initialized when we add the application state. A check has been added to initialize it if it's missing. I suspect that this changed with v5 of `@sentry/browser`, though I can't find any explicit confirmation of this in their changelog.
The UI would crash upon deleting a contact from the contact list. This happened for two reasons: the deletion could result in a re-render before the `history.push` finished navigating back to the contact list (it was a race condition), and the contact entry left behind an invalid `identities` entry when it was removed. The first problem was fixed by making the container components for view and edit contact more tolerant of being passed an `address` that doesn't correspond to a contact. If they are given an address without a contact, `null` is passed to the component via the `address` prop. The component will redirect back to the list when this happens instead rendering. This is more awkward than I'd like, but it was the most sensible way of handling this I could think of without making much more drastic changes to how we're handling routing here. The second problem was caused by the `setAccountLabel` call, which was used to ensure the contact entry for any wallet accounts was kept in-sync with the account label. This was being called even for non- wallet accounts though, which is where this problem arose. This step is now skipped for non-wallet accounts. Fixes MetaMask#9019
This higher-order-component has been unused since MetaMask#6551
The update of `content-hash` was included because I wasn't entirely sure whether or not that involved a functional change, or what that change might be. I also neglected to expand upon the changes made in the `inpage-provider` update, as I couldn't think of a concise way to describe them.
Follows the previously set pattern of colocating styles along side the consuming components. This one was really straight forward and just a reorganization of files and imports. No code changes occurred.
See [`prefer-destructuring`](https://eslint.org/docs/rules/prefer-destructuring) for more information. This change enables `prefer-destructuring` and fixes the issues raised by the rule.
Adds actionable message component and stories
Co-authored-by: Patryk Łucka <[email protected]>
The web3 usage metrics added in MetaMask#9144 assumed that all web3 properties were strings. When a `Symbol` property is accessed, our `inpage.js` script crashes because the `Symbol` cannot be serialized correctly. A check has been added for non-string property access. The metric event in these cases is set to the string "typeof ", followed by the type of the key. (e.g. `typeof symbol` for a `Symbol` property). Fixes MetaMask#9234
No commits have been omitted.
* hide advance gas on non mainnet * hide edit gas button on non mainnet
Co-authored-by: Patryk Łucka <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>
This change updates the shared ESLint config to the latest published version, v3.1.0. From the config [`CHANGELOG.md`][1]: v3.0.1 has disabled `prefer-object-spread` by default, so it has been enabled for this project. [1]:https://github.com/MetaMask/eslint-config/blob/master/CHANGELOG.md
* Hide gas estimate on non-main network (MetaMask#9189) * Update v8.0.9 changelog
Version v8.0.9 RC
* origin/develop: (137 commits) Use @metamask/[email protected] (MetaMask#9275) Standardize scss import practices (MetaMask#9183) Update ESLint shared config to v3 (MetaMask#9274) Add lock icon to default networks (MetaMask#9269) Adds toPrecisionWithoutTrailingZeros utility (MetaMask#9270) Hide gas estimate on non-main network (MetaMask#9189) Move the mascot component to its own directory (MetaMask#9272) Use @metamask/[email protected] (MetaMask#9266) Fix padding, alignment of actionable-message; add left aligned story Code cleanup and simplification for actionable-message component Adds actionable message component and stories Fix lint issues (MetaMask#9265) Fix prefer-destructuring issues (MetaMask#9263) colocate confirm-decrypt-message page styles (MetaMask#9252) Tidy up Migrator tests (MetaMask#9264) Adds pulse loader component (MetaMask#9259) Fix import/order issues (MetaMask#9239) Fix radix issues (MetaMask#9247) New info tooltip component (MetaMask#9180) Improve scss naming ...
this moves very little code around, to enable deleting files that are no longer used or necessary. There are a few more things to move and delete that will be handled in a seperate PR after this one.
Sync `master` with `develop`
* Add react-testing-library Adds react-testing-library as a dependency, creates a wrapper function with Provider store/I18n context support, and implements it in unconnected-account-alert. * Refactor renderWithProvider store to extra param, instead of component prop store
…followMouse (MetaMask#9166) * MetaMask mascot support for provided directions targets and toggling followMouse * Fixes for mascot.component.js * Update metamask-logo version to 2.4.0 * Lint fix * Fix mouse follow updating Co-authored-by: Mark Stacey <[email protected]> * Improve mascot story name Co-authored-by: Mark Stacey <[email protected]> * Update package.json Co-authored-by: Mark Stacey <[email protected]> * Lint fix Co-authored-by: Mark Stacey <[email protected]>
* Remove metamask-logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.