-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: validate ETHBankContract logic #41
base: main
Are you sure you want to change the base?
test: validate ETHBankContract logic #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kateberryd please take a look at the reviews
@@ -12,15 +14,121 @@ describe("ETHBank Test Suite", function () { | |||
|
|||
describe("Post Deployment State Variables", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This describe block should be Deployment
}); | ||
}); | ||
|
||
describe("Transactions", async () => { | ||
describe("Deposit Validations", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under Transactions
, you should have sub-wrappers - Deposit
and Withdrawal
To appropriately categorize your test cases, under each of these, ensure you have corresponding Validation
, Transactions
and Events
describe
wrappers and each with its it
test case
No description provided.