Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip install instructions #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clevinson
Copy link

The gemfury url instructions in the readme are missing a colon (:) after the <TOKEN>, and as a result, the instructions in this readme were not working for me.

I found the solution by reading gemfury's documentation here.

This pr fixes the instructions in the README.md

@markusbkoch
Copy link
Contributor

Thanks, @clevinson . We had been using the command without the colon since the beginning internally. Both work for me:

MarkusPersonal:~ markusbkoch$ pip3 uninstall cadCAD
Uninstalling cadCAD-0.2.4:
  Would remove:
    /usr/local/lib/python3.7/site-packages/cadCAD-0.2.4.dist-info/*
    /usr/local/lib/python3.7/site-packages/cadCAD/*
Proceed (y/n)? y
  Successfully uninstalled cadCAD-0.2.4


MarkusPersonal:~ markusbkoch$ pip3 install cadCAD --extra-index-url https://<TOKEN>@repo.fury.io/blockscience/
Looking in indexes: https://pypi.org/simple, https://repo.fury.io/blockscience/
Collecting cadCAD
  Downloading https://repo.fury.io/blockscience/-/ver_3hbPf/cadCAD-0.2.4-py3-none-any.whl
Installing collected packages: cadCAD
Successfully installed cadCAD-0.2.4


MarkusPersonal:~ markusbkoch$ pip3 uninstall cadCAD
Uninstalling cadCAD-0.2.4:
  Would remove:
    /usr/local/lib/python3.7/site-packages/cadCAD-0.2.4.dist-info/*
    /usr/local/lib/python3.7/site-packages/cadCAD/*
Proceed (y/n)? y
  Successfully uninstalled cadCAD-0.2.4


MarkusPersonal:~ markusbkoch$ pip3 install cadCAD --extra-index-url https://<TOKEN>:@repo.fury.io/blockscience/
Looking in indexes: https://pypi.org/simple, https://repo.fury.io/blockscience/
Collecting cadCAD
  Downloading https://repo.fury.io/blockscience/-/ver_3hbPf/cadCAD-0.2.4-py3-none-any.whl
Installing collected packages: cadCAD
Successfully installed cadCAD-0.2.4

Regardless, I do agree it makes sense to stick to what's in the gemfury documentation. @JEJodesty , any thoughts before we merge this?

@markusbkoch markusbkoch requested a review from JEJodesty August 1, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants