Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

add frame to base object #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add frame to base object #16

wants to merge 4 commits into from

Conversation

Licini
Copy link
Collaborator

@Licini Licini commented Sep 1, 2022

Implemented the frame to base Object, MeshObject, NetworkObject and VolmeshObject. See example of scripts/test_frame.py
It's a bit tricky for CurveObject and LineObject, I couldn't yet find a good place to insert the frame transformation since they directly use the compas core artists. What do you think would be a good way for them? @brgcode

image

@Licini Licini requested a review from tomvanmele September 1, 2022 10:20
@tomvanmele
Copy link
Contributor

i would overwrite the core artists in compas ui for now...

@Licini Licini marked this pull request as ready for review September 2, 2022 13:18
src/compas_ui/objects/object.py Outdated Show resolved Hide resolved
src/compas_ui/objects/object.py Outdated Show resolved Hide resolved
src/compas_ui/rhino/artists/curveartist.py Show resolved Hide resolved
src/compas_ui/rhino/artists/lineartist.py Outdated Show resolved Hide resolved
src/compas_ui/rhino/artists/curveartist.py Outdated Show resolved Hide resolved
src/compas_ui/rhino/objects/lineobject.py Outdated Show resolved Hide resolved
@Licini
Copy link
Collaborator Author

Licini commented Sep 15, 2022

Changed to use the concept view_item, @brgcode what do you think now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants