Implemented_execution_proof_go_execution_errors_go_#30 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DarkLord017 please rebase. |
|
Ok will do |
|
@DarkLord017, why does the lint fails? |
I made a pr when some consensus files were pending maybe that's the reason I will rebase it n then make a commit |
gerceboss
reviewed
Sep 27, 2024
gerceboss
reviewed
Sep 27, 2024
execution/proof.go
Outdated
| return true | ||
| } | ||
|
|
||
| func getRestPath(p []byte, s int) string { |
There was a problem hiding this comment.
Add a comment that this is dead code, just to make it easier for future
gerceboss
reviewed
Sep 27, 2024
|
@DarkLord017 re-request for review whenever you push changes |
Okay sir I will push in few minutes n tag u |
DarkLord017
force-pushed
the
Implemented_execution_proof_go_execution_errors_go_#30
branch
from
507b692
to
394539b
Compare
|
Made the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.