Doc improvements #80
Open
Doc improvements #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing, it seems that only one of these fields can be set. If multiple fields are set, only the first field is acted upon (the other actions are ignored). Should this be converted to a `oneof` type?
tewalds
reviewed
Feb 8, 2018
s2clientprotocol/sc2api.proto
Outdated
| @@ -567,6 +567,8 @@ message Observation { | |||
| optional ObservationUI ui_data = 8; // Populated if Feature Layer or Render interface is enabled. | |||
| } | |||
|
|
|||
| // Only one of these Action fields should be set at once | |||
There was a problem hiding this comment.
Only one of these would be set when making an action, but multiple are likely to be returned when getting the actions back in an observation (eg from a replay) since the action can be represented in multiple ways.
There was a problem hiding this comment.
Good point! I just pushed an update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more info