Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #59: Input output file bugs #60

Merged
merged 8 commits into from
Jul 8, 2022
Merged

Fixed issue #59: Input output file bugs #60

merged 8 commits into from
Jul 8, 2022

Conversation

chandrakant100
Copy link
Contributor

No description provided.

@chandrakant100 chandrakant100 added the enhancement New feature or request label Jul 7, 2022
@chandrakant100 chandrakant100 added this to the Testing and Deployment milestone Jul 7, 2022
@chandrakant100 chandrakant100 linked an issue Jul 7, 2022 that may be closed by this pull request
Input Output file bugs #59
Closed
Ank1taS
Ank1taS suggested changes Jul 7, 2022
View reviewed changes
main.cpp Outdated Show resolved Hide resolved
@H1manshu21 H1manshu21 requested a review from Ank1taS July 7, 2022 17:44
H1manshu21
H1manshu21 requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@H1manshu21 H1manshu21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move checkFile() to main.cpp instead of helpers.cpp because it clutters with the functionalities of filters. It should not mix up with filters function.

helpers.cpp Show resolved Hide resolved
helpers.cpp Outdated Show resolved Hide resolved
@H1manshu21 H1manshu21 changed the title FIxed issue #59: Input output file bugs Fixed issue #59: Input output file bugs Jul 8, 2022
@H1manshu21 H1manshu21 requested review from Ank1taS and H1manshu21 and removed request for Ank1taS July 8, 2022 07:00
Ank1taS
Ank1taS suggested changes Jul 8, 2022
View reviewed changes
main.cpp Outdated Show resolved Hide resolved
@H1manshu21 H1manshu21 requested a review from Ank1taS July 8, 2022 07:32
@chandrakant100 chandrakant100 merged commit f753151 into main Jul 8, 2022
@chandrakant100 chandrakant100 deleted the bugFix branch July 8, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H1manshu21 H1manshu21 H1manshu21 approved these changes

@Ank1taS Ank1taS Ank1taS approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Testing and Deployment
Development

Successfully merging this pull request may close these issues.

Input Output file bugs
3 participants
@chandrakant100 @H1manshu21 @Ank1taS