Refactor chief submitpackage #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herpiko
reviewed
Nov 29, 2020
| return job, errors.New("Can't verify tarball") | ||
| } | ||
|
|
||
| // TODO : we haven't delete the tarball here |
There was a problem hiding this comment.
For now, the upload has been fixed by:
- Uploading the tarball to /v1/submission-upload to get the blob id. They're accessible on https://irgsh.blankonlinux.or.id/submissions/.
- Send submission metadata that included the tarball blob id to get the pipeline ID
Did you plan that this v2 API is providing submission in one strike? I'm thinking about the metadata is included in the tarball.
wejick
force-pushed
the
refactorChiefSubmitpackage
branch
2 times, most recently
from
c39d071
to
eb85106
Compare
Minimizing bash call, the only exec used is for gpg, after much considering and prototyping using the works one seems to be the wiser choice machinery done, tarball deleted
wejick
force-pushed
the
refactorChiefSubmitpackage
branch
from
413cf34
to
bd04ec4
Compare
|
@herpiko help to review and test ya. |
|
regarding the previous breaking change, I think should be fine. will catch up with that changes later |
|
@wejick Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring chief, rewrite the submission API to use native golang function and minimizing bash call
The only exec used is for gpg, after much considering and prototyping using the works one seems to be the wiser choice
machinery done, tarball deleted