Tumbleweed/setup dev env #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgfritch
force-pushed
the
tumbleweed/setup-dev-env
branch
from
f9844c1 to
e9243b5
Compare
The default developer-settings (_default-dev-settings) are not being sourced in, leaving empty defaults in the shell environment when the python script(s) run. dev-rook-ceph # source developer-settings developer-settings: line 3: source: _default-dev-settings: file not found
makelib.mk explicitly unsets the shell environment, causing the "$USER"
var to also be unset. This later results in a bad libvirt dnsmasq domain
that starts with a '-' char ('-rook-dev.net')
mgfritch
force-pushed
the
tumbleweed/setup-dev-env
branch
from
f68cfdf to
53accc0
Compare
BlaineEXE
approved these changes
Aug 6, 2019
| @@ -6,7 +6,8 @@ | |||
|
|
|||
| # Prevent cluster collisions in shared environments with a resource name prefix | |||
| # Can safely be commented-out for local libvirt use | |||
| export CLUSTER_PREFIX="$USER-" | |||
| export USER=$(whoami || echo "default-user") | |||
There was a problem hiding this comment.
I don't think we want a default user. That could still encourage collisions. The intent is that with -u, this will fail if the USER env var is unset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of fixes made during setup on a clean tumbleweed dev. environment.