Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove coc-actions #14

Merged
merged 1 commit into from
Jan 30, 2021
Merged

remove coc-actions #14

merged 1 commit into from
Jan 30, 2021

Conversation

ChrisTsou
Copy link
Contributor

coc-actions seems to be obsolete. this change seems to work like before. Using coc.nvim interface now. I'm still new to this so confirm before merging.

@Blacksuan19
Copy link
Owner

In some languages coc.nvim interface doesn't show some options, that's why coc-actions is still there

@ChrisTsou
Copy link
Contributor Author

ChrisTsou commented Jan 30, 2021

i see, should this close then?. also out of curiosity is there somewhere in coc.nvim where i can see supported action features? which languages you saw a problem with?

@Blacksuan19
Copy link
Owner

In particular the problem is with python, coc-actions will show actions such as extract variable or method, resolve imports and some others while stock coc will only show organize imports and extract method.
Supported actions are from lsp not coc.nvim

@ChrisTsou
Copy link
Contributor Author

ChrisTsou commented Jan 30, 2021

Capture

i don't know python, but in a trivial program the options you mention seem to appear. Is it something else that should be there?
edit: i havent done any setup at all for python dev, this is with what is included in this init.vim

@Blacksuan19
Copy link
Owner

Blacksuan19 commented Jan 30, 2021

am not getting that import option with either coc-actions or coc.nvim which is very weird, anyway coc-action can go I guess, coc.nvim actions are good enough, python is a special case because coc-python is a dead project

@Blacksuan19 Blacksuan19 merged commit a0a630a into Blacksuan19:master Jan 30, 2021
@orestisfl
Copy link
Contributor

am not getting that import option with either coc-actions or coc.nvim which is very weird, anyway coc-action can go I guess, coc.nvim actions are good enough, python is a special case because coc-python is a dead project

Why not switch to pyright?

@Blacksuan19
Copy link
Owner

yes switched already lol, just testing some things before pushing

@ChrisTsou ChrisTsou deleted the coc-actions branch February 19, 2021 21:46
Blacksuan19 added a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants