Better envelope curve control #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MyBlackMIDIScore
commented
Aug 18, 2024
MyBlackMIDIScore
commented
- Added convex and concave lerpers in the envelope
- Added options on the sf init to control the curves for each stage separately (this is modular and can be also used later with modulation envelopes)
- Minor: Fixed the volume limiter not applying to the end of the file in the render module
arduano
requested changes
Aug 18, 2024
arduano
requested changes
Aug 21, 2024
|
This PR needs to be rebased onto the new git history which fixes the licensing error. If you need any help onto doing so feel free to ask |
MyBlackMIDIScore
force-pushed
the
envelope
branch
from
69421f6
to
763df27
Compare
This reverts commit 435a260.
arduano
approved these changes
Aug 22, 2024
|
@Kaydax Please don't force push changes like that again. It messed up the entire repo and I spent a lot of my time trying to fix all conflicts. Next time you want to make a change, create a PR like a normal person. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.