Better multithreading options

[MyBlackMIDIScore]

• Control the number of threads used in threadpools (in ChannelGroup and RealtimeSynth)
• Control whether a threadpool will be used when rendering channels in a ChannelGroup
• Modified the rendered module config and removed defaults (because it includes the channel group config now which doesn't have defaults due to the stream params)
• Off-topic: Removed and ignored vscode config from the repo so everyone can use their own lol

[arduano]

The rest lgtm, nice work

[arduano]

Some(0) isn't really a good magic value, that's why we use enums lol.

E.g. "pub enum ThreadCount" with options One, Auto, Manual(u32) or something like that, where Auto just uses the core count

Also It's nice to have constants for these things, because 90% of use cases are just "auto multithreading per channel" or "auto multithreading per channel per key"

[MyBlackMIDIScore]

E.g. "pub enum ThreadCount" with options One, Auto, Manual(u32) or something like that, where Auto just uses the core count

True that sounds like a better approach. Should also be easier for the user to understand what is going on.

Also It's nice to have constants for these things, because 90% of use cases are just "auto multithreading per channel" or "auto multithreading per channel per key"

You mean make a constant of the enum:

const AUTO_MULTITHREADING: ThreadCount = ThreadCount::Auto

or the struct itself:

const AUTO_MULTITHREADING: ParallelismOptions = ParallelismOptions {
    channel: ThreadCount::Auto,
    key: ThreadCount::Auto,
}

?

[arduano]

Nah I meant making it a constant implemented on the struct, you can have const fields inside impl blocks

[MyBlackMIDIScore]

So like this or a function that returns it?

impl ParallelismOptions {
    const AUTO: Self = ParallelismOptions {
        channel: ThreadCount::Auto,
        key: ThreadCount::Auto,
    };
}

[arduano]

Yeah that, except AUTO_PER_KEY (key and channel) and AUTO_PER_CHANNEL (just channel) with descriptions for each, and an Default implementation that does auto per key

[arduano]

In my opinion at least

[MyBlackMIDIScore]

Yeah that, except AUTO_PER_KEY (key and channel) and AUTO_PER_CHANNEL (just channel) with descriptions for each, and an Default implementation that does auto per key

Alright yeah that sounds good. Shouldn't default be auto for both though? It was like that before (at least for channel).

[MyBlackMIDIScore]

Made the changes, let me know if you meant something else or if there's anything else I should change.
Perhaps the documentation, I am still not sure about it (mostly about the new ones I just added lol)

[arduano]

Anyway just add the constants stuff and I'll check again when I wake up

[arduano]

Should be auto here still, because if you're parallelizing voice processing per key you'd probably also want to parallelize event processing too (which must happen per channel)

Suggested change

	channel: ThreadCount::None,
	channel: ThreadCount::Auto,

[MyBlackMIDIScore]

True, will change this and also use this const for Default. Is it ok to merge after this change?

[arduano]

yeah