Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eaphammer: fix dependencies #4211

Merged
merged 4 commits into from
Sep 25, 2024
Merged

eaphammer: fix dependencies #4211

merged 4 commits into from
Sep 25, 2024

Conversation

D3vil0p3r
Copy link
Contributor

#4182

Added Python 3.12 support.

@D3vil0p3r D3vil0p3r marked this pull request as ready for review September 24, 2024 18:58
@noraj noraj linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Contributor

@noraj noraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of editorconfig

@@ -49,4 +50,3 @@ EOF

chmod +x "$pkgdir/usr/bin/$pkgname"
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your text editor is ignoring https://github.com/BlackArch/blackarch/blob/master/.editorconfig and is removing the final newline. Please check https://editorconfig.org/#pre-installed and check if you need a plugin for your IDE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add double newline directly by GH GUI now on the last commit. Can you check please?

@noptrix noptrix merged commit daa78e7 into BlackArch:master Sep 25, 2024
2 checks passed
@noptrix
Copy link
Contributor

noptrix commented Sep 25, 2024

thank you @D3vil0p3r @noraj

@D3vil0p3r D3vil0p3r deleted the patch-2 branch September 25, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eaphammer: review dependencies
3 participants