Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bqm: enhance packaging #3882

Merged
merged 1 commit into from
Jun 30, 2023
Merged

bqm: enhance packaging #3882

merged 1 commit into from
Jun 30, 2023

Conversation

noraj
Copy link
Contributor

@noraj noraj commented Jun 28, 2023

  • no need to hardcode _gemver and to append it to /usr/lib/ruby/gems/ because that's actually what _gemdir is
  • the official name of gemdir is gemhome
  • ruby -e'puts Gem.default_dir can be replaced by the much simpler and elegant gem env home

@noraj
bqm: enhance packaging
7a7c3c6 
- no need to hardcode _gemver and to append it to /usr/lib/ruby/gems/ because that's actually what _gemdir is
- the official name of gemdir is gemhome
- ruby -e'puts Gem.default_dir can be replaced by the much simpler and elegant gem env home
@noraj noraj requested a review from noptrix as a code owner June 28, 2023 14:47
@noptrix noptrix merged commit d273e38 into master Jun 30, 2023
@noptrix noptrix deleted the bqm/enhance branch June 30, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noptrix noptrix Awaiting requested review from noptrix noptrix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noraj @noptrix