Chip2chip

[yunekorea]

Have created chip2chip device codes based on Bluedbm codes.
Creation and modification have started from the main branch.
Codes that were used when porting chip2chip interface to the Ubuntu for ZCU102 in the first place
are named as chip2chip_base.*.
These are not working properly at this moment, and need a lot of work to be done.
I recommend merging this request to a separate branch.

[BlaCkinkGJ]

Please resolve the conflict in Makefile.

[BlaCkinkGJ]

I will check source code later.

[BlaCkinkGJ]

Could you attach your testing result?

[BlaCkinkGJ]

Please revert this to zero

[BlaCkinkGJ]

Please revert this to zero

[BlaCkinkGJ]

Remove the unnecessary comment.

[BlaCkinkGJ]

#define READ_READY_QUEUE(rgstr_vptr) CTC_In(rgstr_vptr) & READQ_READY_MASK;
is_ready = READ_READY_QUEUE(rgstr_vptr);

[BlaCkinkGJ]

For example,

if you want to avoid stack growth, then please use the static inline.
https://github.com/BlaCkinkGJ/Flash-Translation-Layer/blob/d74f061520ea7ce629074e4166929c06c9a14631/include/page.h#L101C1-L104

const int read_ready_values[] = {
    READ_DATA0_READY_VALUE,
    READ_DATA1_READY_VALUE,
    READ_DATA2_READY_VALUE,
    READ_DATA3_READY_VALUE,
    READ_DATA4_READY_VALUE,
    READ_DATA5_READY_VALUE,
    READ_DATA6_READY_VALUE,
    READ_DATA7_READY_VALUE,
}

#define NUM_ITEMS(s) sizeof(s)/sizeof(s[0])

for (int i = 0; i < NUM_ITEMS(read_ready_values); i++) {
    if((readQ_read & read_ready_values[i]) > 0 ) { // you can make this part to a function.
        ...
    }
}

[BlaCkinkGJ]

Please delete all comments.

[BlaCkinkGJ]

#define READ_DATA0_TAG_MASK (0x7f<<0)
#define READ_DATA1_TAG_MASK (0x7f<<8)
#define READ_DATA2_TAG_MASK (0x7f<<16)

[BlaCkinkGJ]

#include <stdio.h>
#include <inttypes.h>

struct address {
  union {
    struct {
      uint64_t page:16;
      uint64_t block:16;
      uint64_t chip:16;
      uint64_t bus:16;
    } format;
    uint64_t cmd;
  };
};

int main(void) {
  struct address addr;
  addr.cmd = 0;
  addr.format.page = 1;
  addr.format.block = 2;
  addr.format.chip = 1;
  addr.format.bus = 16;
  printf("0x%lx\n", addr.cmd);
  return 0;
}

[BlaCkinkGJ]

I aim to do this.

[BlaCkinkGJ]

Need to be changed

[BlaCkinkGJ]

JFYI, you must check whether you can access the OOB(Out-Of-Bound) area. While I was doing the personal project, I found that a NAND chip can suffer from data corruption more than I expected.

Generally, SLC can be corrupted a single bit. Over SLC(e.g., MLC, TLC), they can be corrupted more than a bit. In other words, if you cannot implement the ECC logic, you might get invalid data from the NAND device.

[BlaCkinkGJ]

I enabled Codacy static code analysis for your base branch. Please check it to improve your source code quality.