Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inheritance wallet - Chapter 2 - Cosigner onboarding #1100
base: master
Are you sure you want to change the base?
Inheritance wallet - Chapter 2 - Cosigner onboarding #1100
Changes from 8 commits
8ccb0df
de524a1
0727e9f
b652b43
db293f2
1cb801d
1e2d710
94ab36d
bff4334
b19ec19
fa7d668
cf0c481
6f3bc77
d068383
2d06685
9e8726b
3bf2c48
ba719d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alice already connected her signing device previously when she created the key. Could the application just automatically make that connection between the newly added wallet and the previously created key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if that would work. During the wallet creation flow Alice's device has never seen the final wallet descriptor, which it needs to enable transaction signing. It has only seen the wallet configuration template and the role of its key in that configuration.