Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore and document how to handle send fees #997

Closed
steynviljoen67 opened this issue Mar 20, 2023 · 9 comments · Fixed by #1025
Closed

Explore and document how to handle send fees #997

steynviljoen67 opened this issue Mar 20, 2023 · 9 comments · Fixed by #1025
Assignees
Milestone

Comments

@steynviljoen67
Copy link
Contributor

Describe your content request

When a customer sends bitcoin to another wallet, fees can be included within the amount you want to send or on top of the amount. There are some slight nuances that creates a bad experience.

This request is to explore and document what the different alternatives are.

Link to the page
Still to be determined

Why would you like to change the content?
We currently don't have this documentation in our guides

Suggestions
No suggestions yet

Additional context
This request came up in the General channel: https://bitcoindesign.slack.com/archives/C014J9ZKXB4/p1678778610650009

@GBKS GBKS added this to the Milestone #19 milestone Mar 20, 2023
@yashrajd
Copy link
Contributor

@steynviljoen67 An example of service provider(s) fees that we discussed: https://twitter.com/bitcoinkeeper_/status/1634953589620891648

These would factor into the considerations for our scenarios.

@steynviljoen67
Copy link
Contributor Author

steynviljoen67 commented Apr 10, 2023 via email

@mouxdesign
Copy link
Collaborator

Adding the draft

@GBKS
Copy link
Contributor

GBKS commented Apr 27, 2023

@yashrajd did you meant to post your comment on issue #989? Seems more relevant there.

@GBKS
Copy link
Contributor

GBKS commented Apr 27, 2023

Just took a look at the document. I think it's a good time to design screen mock-ups for this, you can probably communicate a good part of the content visually.

@steynviljoen67
Copy link
Contributor Author

Cool, I'll put some screens together and circulate for feedback.

@GBKS GBKS self-assigned this Jul 3, 2023
@GBKS
Copy link
Contributor

GBKS commented Jul 3, 2023

Quick update on this issue. @steynviljoen67 is pretty swamped right now so I'll help wrap things up. After reviewing all the work done, I'd recommend that we extract the Fees section in the Daily spending wallet -> Sending page into a separate sub-page. There's already a good amount of information there that we can add Steyn's research to. That will give us a dedicated page for anything related to fees, both onchain and lightning. This is more convenient for readers, and allows us to dive into more detail and edge cases because we have the dedicated space. I'll bring that up in the jam session today and if everyone's OK with it, set up a PR. How does that sound, Steyn?

@steynviljoen67
Copy link
Contributor Author

steynviljoen67 commented Jul 4, 2023 via email

GBKS added a commit that referenced this issue Jul 13, 2023
Picking up work that Steyn did around various fee scenarios, and tried to marry it with what we have in the guide already. The "Send" page had a lot of fee-related info, but adding more there would have resulted in a very long page. That's why I extracting the fee content into a dedicated page that lives underneath the "Send" page.

Closes #997
@GBKS
Copy link
Contributor

GBKS commented Jul 13, 2023

@steynviljoen67 I just created a pull request with my proposal for adding your research, married with the content we already have. Please take a look and let me know what you think.

sbddesign pushed a commit that referenced this issue Sep 20, 2023
* Extract send fees into a page and add scenarios

Picking up work that Steyn did around various fee scenarios, and tried to marry it with what we have in the guide already. The "Send" page had a lot of fee-related info, but adding more there would have resulted in a very long page. That's why I extracting the fee content into a dedicated page that lives underneath the "Send" page.

Closes #997

* Fixed preview image URL

* Apply suggestions from code review

Co-authored-by: Mogashni  <[email protected]>
Co-authored-by: Stephen DeLorme <[email protected]>

* Minor tweaks to address review feedback

---------

Co-authored-by: Mogashni <[email protected]>
Co-authored-by: Stephen DeLorme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

4 participants