Update basic send flow #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed block status/setting bar from mobile screens - Removed QR code scan buttons - New clipboard detection pattern (inline button)
- Removed transaction sent modal - Updated review screens (removed header text) - Updated drag&drop styling
- Updated page content - Added inline validation examples
|
@GBKS I think this is ready for a first review. |
GBKS
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Can you please make a couple of tweaks:
- Little bit of padding for "Send all"
- Make the input field fill the available space so it can be easily tapped to focus.
Would also be nice to be able to tap the available balance in the error message, to "Send all". That might be what the user wants to do.
There was a problem hiding this comment.
If the label field is a fixed width, we may need to define that as well. That could get a little tricky across input fields, we the text size is dynamic and user-adjustable.
GBKS
reviewed
Feb 3, 2025
| image = "/assets/images/send/layout-blocks-address.png" | ||
| retina = "/assets/images/send/[email protected]" | ||
| big = "/assets/images/send/layout-blocks-address-big.png" | ||
| alt-text = "Layout blocks of the address input component." |
There was a problem hiding this comment.
Maybe just throw the image into AI and have it create alt text?
|
Addressed @GBKS's comments. |
- Updated review screen to be a full page modal - Added transaction confirmation screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the follow-up tasks for the basic send flow page that are mentioned in this issue.
More specifically, it: