refactor(blockapis): replace bluebird with native promises #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev-daniell
force-pushed
the
DX-1126-remove-bluebird-from-blockapis
branch
from
dfe52f3 to
399fbf2
Compare
kev-daniell
force-pushed
the
DX-1126-remove-bluebird-from-blockapis
branch
from
399fbf2 to
c61828c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the blockapis module by replacing Bluebird with native Promises. Key changes include:
- Removing the Bluebird dependency.
- Replacing the Bluebird.mapSeries call with a native implementation in the mapSeries function.
- Introducing a custom async mapping implementation intended to mimic sequential processing.
kev-daniell
force-pushed
the
DX-1126-remove-bluebird-from-blockapis
branch
from
c61828c to
6164d7f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the blockapis module by replacing Bluebird with native promises. Key changes include:
- Removal of the Bluebird dependency.
- Implementation of the mapSeries function using async/await to replicate Bluebird.mapSeries behavior.
mullapudipruthvik
previously approved these changes
Mar 17, 2025
OttoAllmendinger
requested changes
Mar 17, 2025
kev-daniell
force-pushed
the
DX-1126-remove-bluebird-from-blockapis
branch
from
6164d7f to
9222357
Compare
zahin-mohammad
previously approved these changes
Mar 17, 2025
lokesh-bitgo
previously approved these changes
Mar 18, 2025
OttoAllmendinger
previously approved these changes
Mar 18, 2025
kaustubhbitgo
previously approved these changes
Mar 18, 2025
kev-daniell
dismissed stale reviews from kaustubhbitgo, OttoAllmendinger, lokesh-bitgo, and zahin-mohammad
via
83e687e
kev-daniell
force-pushed
the
DX-1126-remove-bluebird-from-blockapis
branch
from
83e687e to
25b0f53
Compare
zahin-mohammad
approved these changes
Mar 18, 2025
lokesh-bitgo
approved these changes
Mar 19, 2025
mullapudipruthvik
approved these changes
Mar 19, 2025
aarvay
approved these changes
Mar 19, 2025
saravanan7mani
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DX-1126
TICKET: DX-1126