Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(utxo-bin): add bip32 subcommand #4979

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

OttoAllmendinger
Copy link
Contributor

  • refactor(utxo-bin): add formatTreeOrJson
    Factor out common argument for tree or json output format into a shared
    constant.

    Issue: BTC-1351

  • refactor(utxo-bin): add bip32 subcommand
    Now we have a new command bip32 that has two subcommands:

    • parse that takes a bip32 key and shows its info
    • generateFromSeed that generates a bip32 key from a seed

    This replaces the parseXpub command.

    Issue: BTC-1351

  • feat(utxo-bin): add strict mode to yargs
    This has the effect of making yargs fail if an unknown command is passed.

    Issue: BTC-1351

Factor out common argument for tree or json output format into a shared
constant.

Issue: BTC-1351
Now we have a new command `bip32` that has two subcommands:

- `parse` that takes a bip32 key and shows its info
- `generateFromSeed` that generates a bip32 key from a seed

This replaces the `parseXpub` command.

Issue: BTC-1351
This has the effect of making yargs fail if an unknown command is passed.

Issue: BTC-1351
@OttoAllmendinger OttoAllmendinger changed the title BTC 1351.utxo bin bip32 refactor(utxo-bin): add bip32 subcommand Oct 2, 2024
@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review October 2, 2024 16:03
@OttoAllmendinger OttoAllmendinger requested a review from a team as a code owner October 2, 2024 16:03
@OttoAllmendinger OttoAllmendinger merged commit ecef044 into master Oct 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants