Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-api): enable esModuleInterop #4978

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OttoAllmendinger
Copy link
Contributor

Requires some changes to the imports in the codebase to use the default import
syntax.

Issue: BTC-1351

Requires some changes to the imports in the codebase to use the default import
syntax.

Issue: BTC-1351
@OttoAllmendinger OttoAllmendinger force-pushed the BTC-1351.sdk-api-esmodule-interop branch from e22e62f to 5c884ca Compare October 2, 2024 13:43
@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review October 2, 2024 14:24
@OttoAllmendinger OttoAllmendinger requested review from a team as code owners October 2, 2024 14:24
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me but,

  • lacking context on why we need this change
  • the linked ticket seems irrelevant to this change (maybe it is, its just not obvious to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants