Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-stx): add support to nakamoto updgrade stack-stx tx #4410

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

rliberal-simtlix
Copy link
Contributor

EA-3369

TICKET: EA-3369

@rliberal-simtlix rliberal-simtlix marked this pull request as ready for review April 9, 2024 13:28
@rliberal-simtlix rliberal-simtlix requested review from a team as code owners April 9, 2024 13:28
@evanzbitgo evanzbitgo self-requested a review April 9, 2024 19:16
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush - insufficient context

@rliberal-simtlix
Copy link
Contributor Author

rliberal-simtlix commented Apr 10, 2024

flush - insufficient context
Breaking changes on STX for Nakamoto fork:

Fork:
https://docs.stacks.co/nakamoto-upgrade/nakamoto

Breaking changes in stack-stx staking adds new 4 parameters to contract call and changes from version 3 to 4 POX contract for staking.

https://docs.stacks.co/nakamoto-upgrade/signing-and-stacking/stacking-flow#solo-stacker-flow

PR supports POX-3 and POX-4 because we need to coexist with the two versions of the contract, so changes added full support for POX-4 and backward comp tests with POX-3.

evanzbitgo
evanzbitgo previously approved these changes Apr 10, 2024
modules/express/encryptedPrivKeys.json Outdated Show resolved Hide resolved
evanzbitgo
evanzbitgo previously approved these changes Apr 10, 2024
@evanzbitgo evanzbitgo merged commit ee0a030 into master Apr 10, 2024
6 checks passed
@evanzbitgo evanzbitgo deleted the EA-3369 branch April 10, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants