Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-377 - Add support for Sylius 1.12 and 1.13 #31

Merged
merged 23 commits into from
Sep 16, 2024
Merged

OP-377 - Add support for Sylius 1.12 and 1.13 #31

merged 23 commits into from
Sep 16, 2024

Conversation

SzymonKostrubiec
Copy link
Contributor

  • Add support for Sylius 1.12
  • Add support for Sylius 1.13
  • Drop support for sylius 1.0

Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally there is an approve in advance. Good job! :)

@@ -0,0 +1 @@
* @Sylius/core-team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

.gitignore Outdated
@@ -1,4 +1,3 @@
/bin/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you commit this, then commit bin/create_node_symlink.php, and then roll-back the .gitignore?

src/Resources/config/services.xml Show resolved Hide resolved
tests/Application/Kernel.php Show resolved Hide resolved
@@ -0,0 +1,25 @@
DirectoryIndex app.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed?

@senghe senghe merged commit c2867f3 into master Sep 16, 2024
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants