-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-377 - Add support for Sylius 1.12 and 1.13 #31
Conversation
SzymonKostrubiec
commented
Jul 26, 2024
- Add support for Sylius 1.12
- Add support for Sylius 1.13
- Drop support for sylius 1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally there is an approve in advance. Good job! :)
.github/CODEOWNERS
Outdated
@@ -0,0 +1 @@ | |||
* @Sylius/core-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
.gitignore
Outdated
@@ -1,4 +1,3 @@ | |||
/bin/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why that change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you commit this, then commit bin/create_node_symlink.php
, and then roll-back the .gitignore?
tests/Application/public/.htaccess
Outdated
@@ -0,0 +1,25 @@ | |||
DirectoryIndex app.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file needed?