OP-377 - Apply ECS fixes, update ECS config and update dependencies

composer.json

@@ -19,6 +19,7 @@
         "symfony/webpack-encore-bundle": "^1.16"
     },
     "require-dev": {
+        "doctrine/annotations": "^1.13",
         "bitbag/coding-standard": "^3.0",
         "phpstan/extension-installer": "^1.0",
         "phpstan/phpstan": "^1.8.1",

ecs.php

@@ -1,26 +1,13 @@
 <?php
 
-/*
- * This file was created by developers working at BitBag
- * Do you need more information about us and what we do? Visit our https://bitbag.io website!
- * We are hiring developers from all over the world. Join us and start your new, exciting adventure and become part of us: https://bitbag.io/career
-*/
-
 declare(strict_types=1);
 
-use PhpCsFixer\Fixer\ClassNotation\VisibilityRequiredFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 
-return static function (ECSConfig $ecsConfig): void {
-    $ecsConfig->paths([
-        __DIR__ . '/src',
-        __DIR__ . '/tests/Behat',
-        __DIR__ . '/ecs.php',
-    ]);
+return static function (ECSConfig $config): void {
 
-    $ecsConfig->import('vendor/sylius-labs/coding-standard/ecs.php');
+    putenv('ALLOW_BITBAG_OS_HEADER=1');
 
-    $ecsConfig->skip([
-        VisibilityRequiredFixer::class => ['*Spec.php'],
-    ]);
+    $config->import('vendor/bitbag/coding-standard/ecs.php');
+    $config->paths(['src', 'tests']);
 };

src/Action/CaptureAction.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**
@@ -71,7 +78,7 @@ public function execute($request): void
 
         $transactionReference = $model['transactionReference'] ?? null;
 
-        if ($transactionReference !== null) {
+        if (null !== $transactionReference) {
             if ($this->mercanetBnpParibasBridge->isPostMethod()) {
                 $model['status'] = $this->mercanetBnpParibasBridge->paymentVerification() ?
                     PaymentInterface::STATE_COMPLETED : PaymentInterface::STATE_CANCELLED
@@ -84,7 +91,7 @@ public function execute($request): void
                 return;
             }
 
-            if ($model['status'] === PaymentInterface::STATE_COMPLETED) {
+            if (PaymentInterface::STATE_COMPLETED === $model['status']) {
                 return;
             }
         }

src/Action/ConvertPaymentAction.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**
@@ -40,7 +47,7 @@ public function supports($request)
         return
             $request instanceof Convert &&
             $request->getSource() instanceof PaymentInterface &&
-            $request->getTo() === 'array'
+            'array' === $request->getTo()
         ;
     }
 

src/Action/NotifyAction.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**

src/Action/StatusAction.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**
@@ -53,12 +60,12 @@ public function execute($request): void
             return;
         }
 
-        if ($status === PaymentInterface::STATE_CANCELLED) {
+        if (PaymentInterface::STATE_CANCELLED === $status) {
             $request->markCanceled();
 
             return;
         }
-        if ($status === PaymentInterface::STATE_COMPLETED) {
+        if (PaymentInterface::STATE_COMPLETED === $status) {
             $request->markCaptured();
 
             return;

src/BitBagMercanetBnpParibasPlugin.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**

src/Bridge/MercanetBnpParibasBridge.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**

src/Bridge/MercanetBnpParibasBridgeInterface.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**

src/DependencyInjection/BitBagMercanetBnpParibasExtension.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**

src/DependencyInjection/Configuration.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 namespace BitBag\MercanetBnpParibasPlugin\DependencyInjection;

src/Form/Type/MercanetBnpParibasGatewayConfigurationType.php

@@ -1,5 +1,12 @@
 <?php
 
+/*
+ * This file has been created by developers from BitBag.
+ * Feel free to contact us once you face any issues or want to start
+ * You can find more information about us on https://bitbag.io and write us
+ * an email on [email protected].
+ */
+
 declare(strict_types=1);
 
 /**