Better Liip-Imagine/Gaufrette media integration #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Crty
force-pushed
the
master
branch
2 times, most recently
from
c6bb73d to
42faada
Compare
fixing path prefix for gaufrette
David-Crty
changed the title
rafalmal
suggested changes
Apr 3, 2023
| @@ -1,6 +1,12 @@ | |||
| <h2>{{ media.name|raw }}</h2> | |||
|
|
|||
| <img class="ui fluid image" src="{{ media.path }}" alt="{{ media.name }}" | |||
| {% if page.image.path starts with 'data:' %} | |||
There was a problem hiding this comment.
This change throws 500 error on main page.
There was a problem hiding this comment.
Hi @David-Crty. I also noticed this 500 error on fresh install with default fixtures.
|
I see no response since last month, so I'm closing this PR. Please reopen it if you still need it @David-Crty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some fixes about the
liip/gaufretteintegration, I only used the filter already available by sylius.Please let me know if I need to do more about this MR 🙏
Because I'm working on a new project, I'm not sure if the change on
setPathis a breaking change 🤔