Visualizing new version of IDEAFilter

[AARON-CLARK]

Corresponding to: https://github.com/Biogen-Inc/IDEAFilter/pull/18/files

With new additions to NEWS file:

• Fix bug that was trying to assign an attribute to a NULL (Demo #15)
• Fix bug that was causing inaccurate filtering for datetime vectors (adding across to uploaded data and raw datasets #17)
• Add new implementation IDEAFilter() that uses a more modern implementation and less resources (Have github icon link to tidyCDISC repo #22)
• Allow user to restrict filter to a subset of columns (Add minimum screen width. #14)
• Upgraded pillar::new_pillar_type() to pillar::type_sum() (Batch Download: Automatically adjust the size of the watermark  #9)
• Allow user to easily erase the applied filters
• Delete inputs and observers from vector modules when exiting them

[AARON-CLARK]

@Jeff-Thompson12 Look good. I made a few minor comments below.

[AARON-CLARK]

is shiny_data_filter still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter IDEAFilter
	#' @importFrom IDEAFilter IDEAFilter

[AARON-CLARK]

Is shiny_data_filter_ui still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui
	#' @importFrom IDEAFilter IDEAFilter_ui

[AARON-CLARK]

Is shiny_data_filter_ui still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui
	#' @importFrom IDEAFilter IDEAFilter_ui

[AARON-CLARK]

Is shiny_data_filter_ui still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter_ui IDEAFilter_ui
	#' @importFrom IDEAFilter IDEAFilter_ui

[AARON-CLARK]

is shiny_data_filter still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter IDEAFilter
	#' @importFrom IDEAFilter IDEAFilter

[AARON-CLARK]

is shiny_data_filter still required?

Suggested change

	#' @importFrom IDEAFilter shiny_data_filter IDEAFilter
	#' @importFrom IDEAFilter IDEAFilter

[Jeff-Thompson12]

@AARON-CLARK the answer to all the above is "No". I set this branch up as an easy way to see the new look and performance of the improved IDEAFilter (also helped me find and fix a few bugs). Once we update IDEAFilter on CRAN, I will work more formally to integrate it into tidyCDISC.

[codecov]

Codecov Report

Merging #247 (f74280f) into devel (19a0559) will increase coverage by 4.08%.
Report is 82 commits behind head on devel.
The diff coverage is 71.97%.

❗ Current head f74280f differs from pull request most recent head 8bf38e0. Consider uploading reports for the commit 8bf38e0 to get more accurate results

@@            Coverage Diff             @@
##            devel     #247      +/-   ##
==========================================
+ Coverage   19.26%   23.35%   +4.08%     
==========================================
  Files          54       56       +2     
  Lines        4771     5036     +265     
==========================================
+ Hits          919     1176     +257     
- Misses       3852     3860       +8     

Files Changed	Coverage Δ
R/mod_indvExp_srv.R	0.00% <0.00%> (ø)
R/mod_indvExp_ui.R	0.00% <0.00%> (ø)
R/mod_popExp.R	0.00% <0.00%> (ø)
R/mod_popExp_ui.R	0.00% <0.00%> (ø)
R/mod_tableGen.R	0.00% <0.00%> (ø)
R/mod_tableGen_ui.R	0.00% <0.00%> (ø)
R/mod_tableGen_utils.R	0.00% <0.00%> (ø)
R/zzz.R	0.00% <0.00%> (ø)
R/blockData.R	68.92% <68.92%> (ø)
R/mod_tableGen_fct_methods.R	74.28% <92.70%> (+20.23%)	⬆️

... and 2 files with indirect coverage changes