Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataset deprecation guidelines #121

Merged
merged 1 commit into from
May 6, 2024
Merged

Update dataset deprecation guidelines #121

merged 1 commit into from
May 6, 2024

Conversation

LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented May 2, 2024

With R 4.4.0, our "deprecating a dataset" guidelines are out-of-date. Here is the proposed update.

@LiNk-NY LiNk-NY requested review from hpages and lshep May 2, 2024 18:24
@lshep
Copy link
Contributor

lshep commented May 3, 2024

I'm good with this if @hpages is ? This would close #120 correct?

@LiNk-NY LiNk-NY mentioned this pull request May 3, 2024
Closed
@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented May 3, 2024

I'm good with this if @hpages is ? This would close #120 correct?

Thanks, I hadn't seen #120 but I responded to the question.
The error may have been due to order of operations.

@lshep lshep merged commit f69ecbc into devel May 6, 2024
2 checks passed
@LiNk-NY LiNk-NY deleted the dataset_deprecation branch September 25, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpages hpages Awaiting requested review from hpages

@lshep lshep Awaiting requested review from lshep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiNk-NY @lshep