Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest settings #309

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Ingest settings #309

merged 7 commits into from
Feb 20, 2025

Conversation

sherwoodf
Copy link
Contributor

@sherwoodf sherwoodf commented Feb 18, 2025

Copy link
Contributor

@kbab kbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only 2 minor comments, but happy to merge as is.

@@ -96,6 +127,7 @@ def find_unprocessed_studies(output_file: Optional[pathlib.Path]):
/ f"uningested_studies_of_interest_{str(date.today())}"
)

logging.info(f"Writing uninstest studies to: {output_file}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

get_func = get_bia_api_client.__getattribute__(f"get_{class_name}")
for expected_object in expected_objects:
persisted_object = get_func(str(expected_object.uuid))
# Using the model_dump_json instead of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment complete? (actual models)

Copy link
Contributor

@kbab kbab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbab kbab merged commit 8fe514f into main Feb 20, 2025
17 of 23 checks passed
@kbab kbab deleted the ingest_settings branch February 20, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants