-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest settings #309
Ingest settings #309
Conversation
…ork out list of uningested studies
429a714
to
f46599f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only 2 minor comments, but happy to merge as is.
@@ -96,6 +127,7 @@ def find_unprocessed_studies(output_file: Optional[pathlib.Path]): | |||
/ f"uningested_studies_of_interest_{str(date.today())}" | |||
) | |||
|
|||
logging.info(f"Writing uninstest studies to: {output_file}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo?
get_func = get_bia_api_client.__getattribute__(f"get_{class_name}") | ||
for expected_object in expected_objects: | ||
persisted_object = get_func(str(expected_object.uuid)) | ||
# Using the model_dump_json instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the comment complete? (actual models)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket: https://app.clickup.com/t/8697r3x3q and https://app.clickup.com/t/8697pkdyf