fix typo and add comments #288
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbab
reviewed
Jan 24, 2025
| @@ -492,7 +492,7 @@ def get_taxon_dict(completeness=Completeness.COMPLETE) -> dict: | |||
|
|
|||
| def get_attribute_dict(completeness=Completeness.COMPLETE) -> dict: | |||
| attribute = { | |||
| "provenance": semantic_models.AttributeProvenance.submittor, | |||
| "provenance": semantic_models.AttributeProvenance.bia_ingest, | |||
There was a problem hiding this comment.
According to the comment above the "submitter" Enum definition it feels like this should be semantic_models.AttributeProvenance.submitter . I am happy to modify this in the ingest code for FileReferences, and you can just change the spelling of submittor -> submitter here. What do you think?
There was a problem hiding this comment.
This is kind of an generic/example attribute that gets used everywhere in the tests (i.e. every object with attributes), so i'm not sure it matters much - even though it says 'file_list_columns' in the name. I don't really mind what's here for the test as long as it passes. But since we don't use the submitter anywhere in our code, i question it's use in general.
kbab
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: it looks like we kind of have overlapping use cases - technically bia-ingest is the thing that's always touching the data provided by submitters, but maybe we want to keep the distinction?
Ticket: https://app.clickup.com/t/8697d3tyd