Dockercompose to unify all the docker components #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviuba
reviewed
Jul 30, 2024
|
@liviuba, I rebased on api_shared_datamodels when I maybe shouldn't have as I have commits from other branches in here too. Making this one a draft as a result |
|
Fun one, Just now I tried to rebase my local api_shared_datamodels on this branch and there was a merge conflict because I tried the older docker compose instead of I then went back into the git history and modified that from a delete and create to a
|
ctr26
changed the title
liviuba
approved these changes
Aug 2, 2024
|
|
||
| CMD ["poetry", "run", "uvicorn", "--workers", "4", "--port", "8080", "--log-config", "./src/log_config.yml", "--host", "0.0.0.0", "src.app:app"] | ||
| CMD ["poetry", "run", "uvicorn", "--workers", "4", "--port", "8080", "--log-config", ".api/src/log_config.yml", "--host", "0.0.0.0", "api.app:app"] |
There was a problem hiding this comment.
I'm too good at fixing files in the git history so now I'll never look like I've made a mistake ever again lol
* updated shared model tests * [feat] testing multiple projects (not clean) * [bug] python 3.11 minimum? * [bug] ./ might be an issue? * [bug] two extra " --------- Co-authored-by: Francois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liviuba
I've made a start on moving the docker-compose file to the root dir. This should improve readability, expandability and fix the context issue.
Also solves the issue of what files are ignored by docker ignore
This context issue is that the api project can't see files from the other projects unless the context is set correctly.
Hope this helps,