Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Testing multiple projects (not clean) #130

Merged
merged 5 commits into from
Jul 30, 2024
Merged

CI Testing multiple projects (not clean) #130

merged 5 commits into from
Jul 30, 2024

Conversation

ctr26
Copy link
Contributor

@ctr26 ctr26 commented Jul 30, 2024

@sherwoodf Is this what you were thinking?

Added a matrix to the current CI so that it tests multiple folders. Negative here is that someone will need to edit the GitHub ci to add anymore subproject to testing

@sherwoodf
Copy link
Contributor

ooo, kind of, i was trying to create one workflow per package, but i'm no expert on setting up these workflows (currently trying to get act working to test what i've made...) If this works and runs all the tests it sounds good to me.

@ctr26 ctr26 requested review from liviuba and sherwoodf July 30, 2024 14:54
@ctr26 ctr26 changed the title Testing multiple projects (not clean) CI Testing multiple projects (not clean) Jul 30, 2024
Copy link
Contributor

@sherwoodf sherwoodf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ctr26 ctr26 mentioned this pull request Jul 30, 2024
@sherwoodf sherwoodf merged commit 5f88274 into main Jul 30, 2024
33 checks passed
ctr26 added a commit that referenced this pull request Jul 31, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 1, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 2, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 2, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 2, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 2, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
ctr26 added a commit that referenced this pull request Aug 2, 2024
* updated shared model tests

* [feat] testing multiple projects (not clean)

* [bug] python 3.11 minimum?

* [bug] ./ might be an issue?

* [bug] two extra "

---------

Co-authored-by: Francois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants