Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated example study output #129

Closed
wants to merge 1 commit into from
Closed

updated example study output #129

wants to merge 1 commit into from

Conversation

sherwoodf
Copy link
Contributor

Updated example output from study conversion.

Does not yet contain versions etc from Liviu's open PR.

{
"uuid": "UUID-image-representation-1",
"representation_of": "UUID-experimentally-captured-image-1",
"original_file_reference": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards linking from Image Representation -> file reference, even if this will potentially be 1: A few.

I suspect File Reference -> Image Representation would be 1:1 most of the time judging by current code (only 1 image rep. gets linked back to a file reference - i'm assuming this is expected)

However, this feels better from the point of view of containing create/update operations. If you create a new image rep, you can link back to the original file references. This seems preferable compared to having to go the original file references and update them to point to the new image rep. Thoughts?

"analysis_method": [],
"correlation_method": [],
"file_reference_count": 1,
"image_count": 1,
"example_image_uri": [],
"attribute": {
"associatations": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: associatations written instead of associations!

@sherwoodf sherwoodf marked this pull request as draft August 16, 2024 11:57
@sherwoodf sherwoodf closed this Aug 27, 2024
@sherwoodf
Copy link
Contributor Author

Closing this - will updated propperly once models have gone through more review

@sherwoodf sherwoodf deleted the update_examples branch December 9, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants