Shared models mongofy #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviuba
force-pushed
the
shared_models_mongofy
branch
from
c2fd09f to
b08e0bb
Compare
sherwoodf
reviewed
Jul 30, 2024
| author: List[semantic_models.Contributor] = Field(min_length=1) | ||
| description: str = Field() |
There was a problem hiding this comment.
this is overriding a field in the semantic model
sherwoodf
reviewed
Jul 30, 2024
|
|
||
|
|
||
| class FileReference( | ||
| semantic_models.FileReference, | ||
| DocumentMixin, | ||
| ): | ||
| submission_dataset_uuid: UUID = Field() | ||
| submission_dataset: UUID = Field() |
There was a problem hiding this comment.
are we or are we not going with _uuid fields?
sherwoodf
reviewed
Jul 30, 2024
…n version control
liviuba
force-pushed
the
shared_models_mongofy
branch
from
7479e03 to
f9cd3c1
Compare
|
I will start work on tests fixes ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://app.clickup.com/t/86956qv26
Not tested, api still wip