removed dataset type enums for validation #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liviuba
pushed a commit
that referenced
this pull request
Jul 31, 2024
ctr26
pushed a commit
that referenced
this pull request
Jul 31, 2024
ctr26
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These enums were created to deal with different types at the end of the submitted_in_dataset_uuid paths, but we think this could be better handled by using two subclasses (thought this might introduce the same issue with the link from derived image -source_image-> file representation). In any case, this should probably be looked into when desiging the UUID validation & have more thinking about it (perhaps a design doc). Removing for now, and cut this ticket https://app.clickup.com/t/86956e5g9 to track the follow-up work.