Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom activity table view cell changes #7

Merged
merged 8 commits into from
Jan 13, 2019
Merged

Custom activity table view cell changes #7

merged 8 commits into from
Jan 13, 2019

Conversation

damiandara
Copy link

Changes:

  1. Added new date time formatter for displaying short style time string values
  2. Removed "cellBackgroundColor" property from the CustomActivityTableViewCell so that the color is populated based on the activity's "tintColor" property
  3. Removed references to the deleted "cellBackgroundColor" property
  4. Updated cell's valueLabel and updatedAtLabel appearance according to the wireframes

Screeshots:

  1. Updated cell appearance for the activities of type "assessment"
    simulator screen shot - iphone xr - 2019-01-13 at 18 24 31

Damian Dara added 3 commits January 13, 2019 17:57
Add helper function for formatting short style time from date
e2c340e
Remove backgroundColor property from the cell and update color based …
e1f16f1 
…on the activity's tintColor + change logic for displaying "value" and "updatedAt" labels according to the designs
Swap default cell for activities of "assessment" type to CustomActivi…
a25c2ea 
…tyTableViewCell + remove references to the removed cellBackgroundColor property
@damiandara damiandara requested a review from tizaks January 13, 2019 07:34
Damian Dara added 5 commits January 14, 2019 07:14
Change section sub-header's font + increase left padding
2e0d223
1. Add different sub-header title for an non-empty, "non-prescribed t…
534f919 
…rackables" table view section

2. Remove forcing optional activities to be merged into a single "Optional" section
Include tintColor parameter in the healthDataEntry initialiser
b276935
Make sure sub-header label text value is an empty string for sections…
d290232 
… different than "non-prescribed trackables" section + add disclosure indicators
Add CustomSegmentedControl section + change logic inside the OCKCareC…
20ea80b 
…ontentsViewController to display newly added section only for the "non-prescribed trackables" table view section
@damiandara damiandara merged commit 2dd8104 into master Jan 13, 2019
@damiandara damiandara deleted the custom-activity-table-view-cell-changes branch January 13, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tizaks tizaks tizaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damiandara @tizaks