added auto shapes #175
Open
added auto shapes #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Bihaqo
reviewed
Jan 31, 2019
| CRITERIONS = ['entropy', 'var'] | ||
|
|
||
|
|
||
| def _to_list(p): |
There was a problem hiding this comment.
Docstring here and everywhere with the style
"""One line TLDR.
(optional details)
Args:
arg1: ...
Returns:
lorem ipsum
"""
|
|
||
| def _roundrobin(*iterables): | ||
| "roundrobin('ABC', 'D', 'EF') --> A D E B F C" | ||
| # Recipe credited to George Sakkis |
There was a problem hiding this comment.
Are you obeying the license of this code if it is not you who wrote it?
There was a problem hiding this comment.
This is from the examples here https://docs.python.org/2.7/library/itertools.html#recipes
t3f/nn.py
Outdated
|
|
||
|
|
||
| class KerasDense(Layer): | ||
| _counter = count(0) | ||
|
|
||
| def __init__(self, input_dims, output_dims, tt_rank=2, | ||
| def __init__(self, in_dim=None, out_dim=None, d=None, mode='mixed', |
There was a problem hiding this comment.
I don't like the naming in_dim vs input_dims. Maybe in_dim vs in_shape?
There was a problem hiding this comment.
BTW, do you actually need in_dims? Can you use just "units" like keras does?
| return _to_list(factorint(p)) | ||
|
|
||
|
|
||
| def auto_shape(n, d=3, criterion='entropy', mode='ascending'): |
There was a problem hiding this comment.
You have default d here but not in KerasDense. Is it intentional?
| return list(factors[i]) | ||
|
|
||
|
|
||
| def suggest_shape(n, d=3, criterion='entropy', mode='ascending'): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.