ADD argNorm version number to tsv outputs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current argNorm version number is now added to tsv outputs under the 'argNorm_version' column
|
I don't like this format. I know hAMRonizer does it like this, so it could be fine for hamronized results, but not for the argNorm ones. I would prefer it as a comment at the top of the file. |
|
Also, there needs to be documentation of the output formats |
Tsv outputs will now have the argNorm version on the top as a comment, such as: "# argNorm version: 0.6.0". Tests in test_normalizers.py now skip the first row of the golden files that contain the argNorm version. `get_golden_file` function was added to test_normalizers.py to make changing the procurement of golden files easier.
luispedro
requested changes
Oct 8, 2024
luispedro
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current argNorm version number is now added to tsv outputs under the 'argNorm_version' column to match with the way the software versions of ARG annotation tools are listed