-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bob/fix landing #2649
Bob/fix landing #2649
Changes from all commits
5fca84b
06c9e22
1a48f2f
2e99610
5803a40
a9bffe8
c610451
e4e8f8b
ddb62bf
8a24dda
84c0a45
e2c694b
0d4e6f8
4718c4c
4fd331c
94a376b
9b9c4de
5abea52
1742288
cbeff22
6b05341
8af9607
ad2f9f4
8f43edc
282a116
57521f3
f9d9055
95cf687
f47aaad
ebafc21
36c5eff
218ca28
8f150ff
24d2394
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ export default defineConfig(({ mode }) => { | |
resolve: { | ||
alias: { | ||
"@": path.resolve(__dirname, "./src"), | ||
"@/assets": path.resolve(__dirname, "../../public/assets"), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Misaligned public directory configurations The current setup has inconsistent public directory configurations:
These paths should be aligned to use the same base public directory to ensure correct asset serving and building. 🔗 Analysis chainVerify assets directory structure and alignment. The new alias points to 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if both directories exist and their relationship
echo "Checking public directories..."
fd -t d "public$" --max-depth 3
echo "Checking assets directories..."
fd -t d "assets$" --max-depth 4
Length of output: 246 Script: #!/bin/bash
# Check the vite config file for publicDir setting
echo "Checking vite.config.ts content..."
cat client/apps/landing/vite.config.ts
Length of output: 1145 |
||
}, | ||
}, | ||
server: { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move vite-plugin-pwa to dependencies section.
The vite-plugin-pwa entry is incorrectly placed in the scripts section. It should be moved to the dependencies section.