new structure #2622
Merged
new structure #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request involves removing a Git submodule and a tool versions configuration file, and introducing a new Changes
Sequence Diagramgraph TD
A[Developer] -->|New Project Setup| B[package.json]
B -->|Defines| C[Project Metadata]
B -->|Configures| D[Development Scripts]
B -->|Specifies| E[Dependencies]
B -->|Includes| F[Dev Dependencies]
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
client/apps/game/package.json (3)
2-4: Consider updating the version number.The version is set to "0.0.0" which typically indicates an initial setup. Consider setting an appropriate version number that reflects the project's maturity and follows semantic versioning principles.
5-14: Add lint scripts to package.json.ESLint dependencies are present but there are no lint scripts defined. Consider adding the following scripts:
"scripts": { "dev": "vite", "build": "tsc && vite build", "preview": "vite preview", "test": "vitest run", "test:watch": "vitest", "test:ui": "vitest --ui", "coverage": "vitest run --coverage", - "generate-pwa-assets": "pwa-assets-generator" + "generate-pwa-assets": "pwa-assets-generator", + "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 0", + "lint:fix": "eslint . --ext ts,tsx --fix" },
76-76: Consolidate SVG plugins.Two SVG-related Vite plugins are included:
- @svgr/rollup
- vite-plugin-svgr
Consider using only vite-plugin-svgr as it's specifically designed for Vite.
"devDependencies": { - "@svgr/rollup": "^8.1.0", // ... other dependencies ...Also applies to: 103-103
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (200)
client/apps/docs/public/03.pngis excluded by!**/*.pngclient/apps/docs/public/bridge.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/archery.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/bank.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/barracks.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/farm.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/fishing_village.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/forge.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/fragment_mine.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/hyperstructure.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/lumber_mill.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/market.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/mine.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/stable.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/storehouse.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/wonder.pngis excluded by!**/*.pngclient/apps/docs/public/buildings/workers_hut.pngis excluded by!**/*.pngclient/apps/docs/public/controller.pngis excluded by!**/*.pngclient/apps/docs/public/eternum_documentation.pngis excluded by!**/*.pngclient/apps/docs/public/eternum_new_logo.svgis excluded by!**/*.svgclient/apps/docs/public/eternum_words_logo.svgis excluded by!**/*.svgclient/apps/docs/public/gifs/bridge-in.gifis excluded by!**/*.gifclient/apps/docs/public/gifs/bridge-out-final.gifis excluded by!**/*.gifclient/apps/docs/public/gifs/bridge-out-start.gifis excluded by!**/*.gifclient/apps/docs/public/gifs/final-bridge-in.gifis excluded by!**/*.gifclient/apps/docs/public/logos/BuiltDojo.svgis excluded by!**/*.svgclient/apps/docs/public/logos/Cartridge.pngis excluded by!**/*.pngclient/apps/docs/public/logos/Dojo.svgis excluded by!**/*.svgclient/apps/docs/public/logos/RealmsWorld.pngis excluded by!**/*.pngclient/apps/docs/public/logos/Starknet.pngis excluded by!**/*.pngclient/apps/docs/public/map.pngis excluded by!**/*.pngclient/apps/docs/public/og-image.pngis excluded by!**/*.pngclient/apps/docs/public/resources/1.pngis excluded by!**/*.pngclient/apps/docs/public/resources/10.pngis excluded by!**/*.pngclient/apps/docs/public/resources/11.pngis excluded by!**/*.pngclient/apps/docs/public/resources/12.pngis excluded by!**/*.pngclient/apps/docs/public/resources/13.pngis excluded by!**/*.pngclient/apps/docs/public/resources/14.pngis excluded by!**/*.pngclient/apps/docs/public/resources/15.pngis excluded by!**/*.pngclient/apps/docs/public/resources/16.pngis excluded by!**/*.pngclient/apps/docs/public/resources/17.pngis excluded by!**/*.pngclient/apps/docs/public/resources/18.pngis excluded by!**/*.pngclient/apps/docs/public/resources/19.pngis excluded by!**/*.pngclient/apps/docs/public/resources/2.pngis excluded by!**/*.pngclient/apps/docs/public/resources/20.pngis excluded by!**/*.pngclient/apps/docs/public/resources/21.pngis excluded by!**/*.pngclient/apps/docs/public/resources/22.pngis excluded by!**/*.pngclient/apps/docs/public/resources/249.pngis excluded by!**/*.pngclient/apps/docs/public/resources/250.pngis excluded by!**/*.pngclient/apps/docs/public/resources/251.pngis excluded by!**/*.pngclient/apps/docs/public/resources/252.pngis excluded by!**/*.pngclient/apps/docs/public/resources/253.pngis excluded by!**/*.pngclient/apps/docs/public/resources/254.pngis excluded by!**/*.pngclient/apps/docs/public/resources/255.pngis excluded by!**/*.pngclient/apps/docs/public/resources/29.pngis excluded by!**/*.pngclient/apps/docs/public/resources/3.pngis excluded by!**/*.pngclient/apps/docs/public/resources/4.pngis excluded by!**/*.pngclient/apps/docs/public/resources/5.pngis excluded by!**/*.pngclient/apps/docs/public/resources/6.pngis excluded by!**/*.pngclient/apps/docs/public/resources/7.pngis excluded by!**/*.pngclient/apps/docs/public/resources/8.pngis excluded by!**/*.pngclient/apps/docs/public/resources/9.pngis excluded by!**/*.pngclient/apps/docs/public/ring_pass.pngis excluded by!**/*.pngclient/apps/game/public/cursor-cross.pngis excluded by!**/*.pngclient/apps/game/public/cursor.pngis excluded by!**/*.pngclient/apps/game/public/draco/draco_decoder.wasmis excluded by!**/*.wasmclient/apps/game/public/draco/gltf/draco_decoder.wasmis excluded by!**/*.wasmclient/apps/game/public/grab.pngis excluded by!**/*.pngclient/apps/game/public/hex-bg.pngis excluded by!**/*.pngclient/apps/game/public/images/Eternum-Mark-Black.pngis excluded by!**/*.pngclient/apps/game/public/images/apple-touch-icon-180x180.pngis excluded by!**/*.pngclient/apps/game/public/images/argent-x.svgis excluded by!**/*.svgclient/apps/game/public/images/avatars/01.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/02.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/03.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/04.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/05.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/06.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/07.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/08.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/09.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/10.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/11.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/12.pngis excluded by!**/*.pngclient/apps/game/public/images/avatars/mercenary.pngis excluded by!**/*.pngclient/apps/game/public/images/braavos.svgis excluded by!**/*.svgclient/apps/game/public/images/buildings/construction/archery.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/barracks.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/dragonhide.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/farm.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/fishing_village.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/forge.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/lumber_mill.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/market.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/mine.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/stable.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/storehouse.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/construction/workers_hut.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/archer-tower.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/army.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/banks.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castle.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castleOne.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castleThree.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castleTwo.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/castleZero.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/crane.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/discord.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/fragment-mine.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/guilds.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/house.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/hyperstructure.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/leaderboard.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/military.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/question-wood.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/question.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/realm.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/resources.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/rewards.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/scale.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/settings.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/silo.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/squire.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/sword.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/timeglass.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/trade.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/trophy.pngis excluded by!**/*.pngclient/apps/game/public/images/buildings/thumb/world-map.pngis excluded by!**/*.pngclient/apps/game/public/images/cover.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/01.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/02.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/03.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/04.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/05.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/06.pngis excluded by!**/*.pngclient/apps/game/public/images/covers/07.pngis excluded by!**/*.pngclient/apps/game/public/images/eternum-logo.svgis excluded by!**/*.svgclient/apps/game/public/images/eternum-logo_animated.pngis excluded by!**/*.pngclient/apps/game/public/images/eternum_logo.pngis excluded by!**/*.pngclient/apps/game/public/images/eternum_with_snake.pngis excluded by!**/*.pngclient/apps/game/public/images/eternumloader.pngis excluded by!**/*.pngclient/apps/game/public/images/favicon.icois excluded by!**/*.icoclient/apps/game/public/images/icons/250.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/251.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/252.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/attack.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/claim.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/leave-battle.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/raid.pngis excluded by!**/*.pngclient/apps/game/public/images/icons/troop.pngis excluded by!**/*.pngclient/apps/game/public/images/maskable-icon-512x512.pngis excluded by!**/*.pngclient/apps/game/public/images/og-image.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/anger.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/brilliance.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/detection.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/enlightenment.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/fox.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/fury.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/giants.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/perfection.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/power.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/protection.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/rage.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/reflection.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/skill.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/titans.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/twins.pngis excluded by!**/*.pngclient/apps/game/public/images/orders/vitriol.pngis excluded by!**/*.pngclient/apps/game/public/images/oroborus.pngis excluded by!**/*.pngclient/apps/game/public/images/pwa-192x192.pngis excluded by!**/*.pngclient/apps/game/public/images/pwa-512x512.pngis excluded by!**/*.pngclient/apps/game/public/images/pwa-64x64.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/1.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/10.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/11.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/12.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/13.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/14.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/15.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/16.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/17.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/18.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/19.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/2.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/20.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/21.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/22.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/254.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/255.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/29.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/3.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/4.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/5.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/6.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/7.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/8.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/9.pngis excluded by!**/*.pngclient/apps/game/public/images/resources/coin.pngis excluded by!**/*.pngclient/apps/game/public/images/squire.pngis excluded by!**/*.pngclient/apps/game/public/map.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
.gitmodules(0 hunks).tool-versions(0 hunks)client/apps/game/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .gitmodules
- .tool-versions
⏰ Context from checks skipped due to timeout of 90000ms (17)
- GitHub Check: test-various (test_ownership_systems)
- GitHub Check: test-various (transport_test)
- GitHub Check: test-various (guild_test)
- GitHub Check: test-various (realm_test)
- GitHub Check: test-various (trade_test)
- GitHub Check: test-various (resource_bridge_test)
- GitHub Check: test-various (map_test)
- GitHub Check: test-various (bank_test)
- GitHub Check: test-various (hyperstructure_test)
- GitHub Check: test-various (config_test)
- GitHub Check: test-various (resources_test)
- GitHub Check: test-various (position_test)
- GitHub Check: test-various (owner_test)
- GitHub Check: test-various (combat_test)
- GitHub Check: test-various (season_test)
- GitHub Check: clippy
- GitHub Check: Run pr agent on every pull request, respond to user comments
🔇 Additional comments (3)
client/apps/game/package.json (3)
36-38: Review Three.js version compatibility.There are multiple Three.js related packages with different version constraints:
- three: ^0.166.0
- @react-three/fiber: ^8.16.1
- @react-three/drei: ^9.101.0
- three-stdlib: ^2.29.5
Ensure these versions are compatible to avoid runtime issues.
Let's check the peer dependencies of these packages:
Also applies to: 62-65
✅ Verification successful
Three.js version compatibility verified ✓
The current Three.js version (^0.166.0) satisfies all peer dependency requirements:
- @react-three/fiber requires >=0.141
- @react-three/drei requires >=0.137
- three-stdlib requires >=0.128.0
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check peer dependencies for Three.js related packages for pkg in @react-three/fiber @react-three/drei three-stdlib; do echo "$pkg peer dependencies:" curl -s "https://registry.npmjs.org/$pkg" | jq -r '.versions | to_entries | .[-1].value.peerDependencies | select(.three != null) | .three' doneLength of output: 910
15-17: Consider using version range for peer dependency.The starknet peer dependency is locked to a specific version (6.11.0). Consider using a version range to allow for compatible updates and reduce potential version conflicts.
Let's verify if there are newer versions available and check for any breaking changes:
22-29: Ensure version consistency across @dojoengine packages.All @dojoengine packages are using alpha versions (1.0.4-alpha.3.1.0), except for @dojoengine/recs which uses ^2.0.13. This version mismatch might cause compatibility issues.
Let's check for the latest stable versions:
Comment on lines
+79
to
+82
| "@types/node": "^20.11.10", | ||
| "@types/react": "^18.2.74", | ||
| "@types/react-dom": "^18.2.21", | ||
| "@types/three": "^0.163.0", |
There was a problem hiding this comment.
💡 Codebase verification
Update @types/three to match runtime version
The @types/three@^0.163.0 is behind the runtime three@^0.166.0. Update it to @types/three@^0.166.0 to ensure type definitions cover all features.
🔗 Analysis chain
Verify TypeScript types versions.
Ensure that @types packages versions match their runtime counterparts:
- @types/react for react@^18.2.0
- @types/three for three@^0.166.0
Let's check the recommended types versions:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check latest @types versions for main packages
for pkg in react three; do
echo "@types/$pkg compatible versions:"
curl -s "https://registry.npmjs.org/@types%2F$pkg" | jq -r '.["dist-tags"].latest'
done
Length of output: 386
Script:
#!/bin/bash
# Check runtime package versions
cat client/apps/game/package.json | jq -r '.dependencies | .["react"], .["three"]'
Length of output: 101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
.tool-versionsfile with Scarb and Dojo version specificationspackage.jsonfor the Eternum client project with comprehensive development scripts and dependencies