add stats resources bridged on empire #2618
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces a new Changes
Sequence DiagramsequenceDiagram
participant User
participant BridgedResources
participant getSeasonAddresses
participant SmartContract
User->>BridgedResources: Render component
BridgedResources->>getSeasonAddresses: Fetch resource addresses
getSeasonAddresses-->>BridgedResources: Return addresses
BridgedResources->>SmartContract: Fetch total supply and balance
SmartContract-->>BridgedResources: Return resource data
BridgedResources->>BridgedResources: Sort and display resources
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Failed to generate code suggestions for PR |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (6)
landing/src/components/modules/bridged-resources.tsx (6)
14-19: Potential data mismatch ifresourceDataremains empty.The state initialization and usage are fine. However, consider a fallback UI or a clear message when
resourceDatais not yet populated, to provide user feedback while awaiting the data fetch.
24-26: Handle fetch failures gracefully.If
getSeasonAddresses()fails, consider logging the error via a user-facing alert or toast, not just the console. This helps the user understand why data may not load.
53-60: Toggle sort directions more explicitly.Your toggle logic is correct. Alternatively, you might consider extracting your toggle logic into a small, reusable helper, which can simplify code if you plan to add more sort keys or complexities later.
63-104: Provide loading or empty states.Rendering
sortedResources.map(...)is correct. In casesortedResourcesis empty, consider providing a loading or empty state UI within the.divide-ycontainer. This prevents a blank view from confusing users while data loads or if none is available.
107-117: Exporting subcomponent.The
BridgeResourcesubcomponent is well-scoped. If it’s only relevant toBridgedResources, consider either keeping it as an inline component or rename it to reflect it is a child within that module (e.g.,BridgedResourceItem) to limit confusion.
172-176: Clipboard success feedback is good.Your approach to setting a small timeout for the “copied” state is good UX. For maximum accessibility, consider also adding an ARIA alert or a short text message that a screen reader can announce.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
landing/src/components/modules/bridged-resources.tsx(1 hunks)landing/src/components/ui/utils/utils.ts(1 hunks)landing/src/routes/index.lazy.tsx(2 hunks)
🔇 Additional comments (6)
landing/src/routes/index.lazy.tsx (1)
131-138: Render new bridged resources in grid layout.
The addition of <BridgedResources /> to the AnimatedGrid items array is clear and straightforward. Ensure that there is proper loading state handling or fallback UI, if <BridgedResources /> requires a lengthy data fetch before rendering. Other than that, this integration looks good.
landing/src/components/modules/bridged-resources.tsx (4)
1-9: Validate dependencies and naming consistency.
These initial imports look consistent and meaningful. Make sure that all external hooks (useDojo, useAccount) are available at runtime and that "BridgedResources" naming is uniform across the codebase to avoid confusion.
28-38: Ensure updateResourceData concurrency safety.
Since you rely on the previous state with setResourceData, concurrency issues are unlikely in React’s standard model, but confirm no race conditions exist if multiple resources update simultaneously.
40-51: Double-check sorting logic.
The sorting approach is clear. However, confirm that mismatched resource data indices never cause sorting anomalies (e.g., if sortedResources adds new entries while resourceData is still partially filled). If that scenario is possible, you may need a synchronization step before sorting.
179-230: Visual consistency of resource item layout.
The markup is consistent. If you foresee expansions or additional functionality (e.g., bridging/unbridging resources), keep this layout flexible by using more modular subcomponents. Otherwise, it looks good.
landing/src/components/ui/utils/utils.ts (1)
439-439: Public interface for shared resource usage.
Exporting ResourceAddresses is a good move for reusability. Confirm that no naming conflict arises with similarly named types in other parts of the codebase.
| const { | ||
| network: { provider }, | ||
| } = useDojo(); | ||
| const { account } = useAccount(); | ||
|
|
||
| const [amountBridged, setAmountBridged] = useState(0n); | ||
| const [playerBalance, setPlayerBalance] = useState(0n); | ||
| const [copied, setCopied] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const fetchData = async () => { | ||
| try { | ||
| // Get total supply | ||
| const totalSupplyResult = await provider.provider.callContract({ | ||
| contractAddress: contractAddress, | ||
| entrypoint: "total_supply", | ||
| }); | ||
| const totalSupply = BigInt(totalSupplyResult[0]); | ||
| setAmountBridged(totalSupply); | ||
|
|
||
| // Get player balance | ||
| let balance = 0n; | ||
| if (account?.address) { | ||
| const balanceResult = await provider.provider.callContract({ | ||
| contractAddress: contractAddress, | ||
| entrypoint: "balance_of", | ||
| calldata: [account.address], | ||
| }); | ||
| balance = BigInt(balanceResult[0]); | ||
| setPlayerBalance(balance); | ||
| } | ||
|
|
||
| onDataUpdate(contractAddress, totalSupply, balance); | ||
| } catch (error) { | ||
| console.error("Error fetching data:", error); | ||
| setAmountBridged(0n); | ||
| setPlayerBalance(0n); | ||
| onDataUpdate(contractAddress, 0n, 0n); | ||
| } | ||
| }; | ||
|
|
||
| fetchData(); | ||
| }, [provider, contractAddress, account?.address, onDataUpdate]); | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Account for Stargate or RPC issues in data fetch.
The callContract logic is correct. For better user experience, consider concurrency handling (e.g., if multiple resources are fetched simultaneously) or repeated calls if the provider becomes momentarily unreachable. If the fetching process is large-scale, you may need batching for performance optimization.
* Fix/donkeys empty balance (#2611) * Merge into main (#2603) * Fix missing arrival when sending lords & donkeys (#2594) * contracts: fix share points check * contracts: fix share points check * Add resource filter for contributions (#2596) * Add resource filter for contributions * Change % for specific resource contribution * Fix missing donkeys in bridge step 2 (#2598) * Fix missing donkeys in bridge step 2 * fix rerenders * Remove filter * Fix registration delay (#2602) * Fix registration delay * styling * Open popup on load * Add burned donkeys back (#2601) --------- Co-authored-by: Credence <[email protected]> Co-authored-by: Loaf <[email protected]> * merge into main (#2605) * Fix missing arrival when sending lords & donkeys (#2594) * contracts: fix share points check * contracts: fix share points check * Add resource filter for contributions (#2596) * Add resource filter for contributions * Change % for specific resource contribution * Fix missing donkeys in bridge step 2 (#2598) * Fix missing donkeys in bridge step 2 * fix rerenders * Remove filter * Fix registration delay (#2602) * Fix registration delay * styling * Open popup on load * Add burned donkeys back (#2601) * im (#2604) --------- Co-authored-by: Credence <[email protected]> Co-authored-by: Loaf <[email protected]> * Fix build (#2610) * filter out donkeys w/ empty balance --------- Co-authored-by: Credence <[email protected]> Co-authored-by: Loaf <[email protected]> * add stats resources bridged on empire (#2618) * add resourcers bridged * change logo * remove looping gql calls (#2620) * remove looping gql calls * batch queries --------- Co-authored-by: Credence <[email protected]> Co-authored-by: Loaf <[email protected]> Co-authored-by: raschel <[email protected]>
* Fix/donkeys empty balance (#2611) * Merge into main (#2603) * Fix missing arrival when sending lords & donkeys (#2594) * contracts: fix share points check * contracts: fix share points check * Add resource filter for contributions (#2596) * Add resource filter for contributions * Change % for specific resource contribution * Fix missing donkeys in bridge step 2 (#2598) * Fix missing donkeys in bridge step 2 * fix rerenders * Remove filter * Fix registration delay (#2602) * Fix registration delay * styling * Open popup on load * Add burned donkeys back (#2601) --------- * merge into main (#2605) * Fix missing arrival when sending lords & donkeys (#2594) * contracts: fix share points check * contracts: fix share points check * Add resource filter for contributions (#2596) * Add resource filter for contributions * Change % for specific resource contribution * Fix missing donkeys in bridge step 2 (#2598) * Fix missing donkeys in bridge step 2 * fix rerenders * Remove filter * Fix registration delay (#2602) * Fix registration delay * styling * Open popup on load * Add burned donkeys back (#2601) * im (#2604) --------- * Fix build (#2610) * filter out donkeys w/ empty balance --------- * add stats resources bridged on empire (#2618) * add resourcers bridged * change logo * remove looping gql calls (#2620) * remove looping gql calls * batch queries --------- Co-authored-by: Loaf <[email protected]> Co-authored-by: Bob <[email protected]> Co-authored-by: Credence <[email protected]>
Summary by CodeRabbit
Release Notes
New Features
Improvements
UI Changes