fix: points

[edisontim]

Summary by CodeRabbit

• Bug Fixes
  • Improved logic for calculating the epoch end timestamp in the leaderboard system, enhancing accuracy in point calculations based on epoch cycles.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 0:22am
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 0:22am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
eternum-landing	⬜️ Ignored (Inspect)	Visit Preview		Dec 27, 2024 0:22am

[coderabbitai]

Walkthrough

The pull request introduces a subtle modification to the getPoints method in the LeaderboardManager class, specifically refining the logic for determining the epochEndTimestamp. The change adjusts how the end timestamp is calculated by adding an additional condition that checks for the existence of nextEpoch when a season is over, potentially impacting how epoch durations are computed.

Changes

File	Change Summary
client/src/dojo/modelManager/LeaderboardManager.ts	Modified getPoints method logic for calculating epochEndTimestamp with a more precise condition

Poem

🐰 In the realm of epochs and time,
A rabbit's logic starts to climb
Timestamps dance with subtle grace
Conditions refined in this code space
Leaderboard magic, precise and bright! 🕒

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 707156b and 089adc4.

📒 Files selected for processing (1)

• client/src/dojo/modelManager/LeaderboardManager.ts (1 hunks)

🔇 Additional comments (1)

client/src/dojo/modelManager/LeaderboardManager.ts (1)

139-142: Validate epochEndTimestamp logic when season.is_over but nextEpoch is defined
Consider a scenario where the season is over yet the next epoch object still exists. In such cases, the code will pick nextEpoch.start_timestamp as the epoch end instead of season.ended_at, potentially conflicting with season-based constraints. If that scenario is valid, consider adding a condition or comment clarifying the intended behavior to make the logic explicit.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed to generate code suggestions for PR