[contracts + client] season pass #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
credence0x
commented
Oct 17, 2024
credence0x
commented
- created a season pass contract as well as a test realms contract
- get realm metadata from contracts rather than passing it through client. now, realms can no longer be duplicated
- remove unnecessary fields from Realm model
- update client to use season pass
- formula optimizations here and there
- separate season pass contracts from eternum because of compilation issues - make realm model smaller - use season pass in client
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You are out of MentatBot reviews. Your usage will refresh October 21 at 07:00 AM. |
| @@ -75,28 +75,29 @@ fn all_resource_ids() -> Array<u8> { | |||
|
|
|||
| // Note: Please update the all_resources_ids list whenever ResourceTypes are updated | |||
| mod ResourceTypes { | |||
| const WOOD: u8 = 1; | |||
There was a problem hiding this comment.
why have these changed?
| Coal = 3, | ||
| Stone = 1, | ||
| Coal = 2, | ||
| Wood = 3, |
There was a problem hiding this comment.
why did ids change?
| } | ||
|
|
||
| #[starknet::contract] | ||
| mod EternumSeasonPass { |
There was a problem hiding this comment.
Where are we going to check that the pass has been used? I think for sanity, we should burn the pass if it is used.
There was a problem hiding this comment.
used passes would be owned by the realms system contract. we transfer the pass to the realms system contract. we could also burn
There was a problem hiding this comment.
Ok - let's leave that. Then we can track as we go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.