Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create octoguns.mdoc #304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create octoguns.mdoc #304

wants to merge 1 commit into from

Conversation

Calcutatator
Copy link

@Calcutatator Calcutatator commented Dec 1, 2024

Can these also be added as images within there (Im not sure wtf to do)

Logo:
OCTOGUNS CIRCLE

Banner:
COVER OCTOGUNS NEW LIGHTS

Page images:
OCTOPUS ILLUSTRATION HOMEPAGE
COVER OCTOGUNS DOK
Concept art Arena Lights
Concept art Octopus 16-9
BUILDINGS OCTOUNS CITY (1)

Summary by CodeRabbit

  • New Features

    • Introduced the game "Octoguns," the first on-chain FPS, with detailed attributes including genres (FPS, Strategy, PVP), developer information, and a description.
    • Added links to the game's homepage, Twitter account, and GitHub repository.
    • The game is now playable and supports web browsers.
  • Documentation

    • Included metadata and longform description for enhanced user understanding.

Copy link

coderabbitai bot commented Dec 1, 2024

Walkthrough

The changes introduce a new file for the game "Octoguns," which includes comprehensive metadata detailing its attributes. This metadata encompasses the game's name, ID, developer, genres, color, status, descriptions, supported operating systems, blockchain chains, and associated tokens. Links to the game's homepage, Twitter account, and GitHub repository are also provided. The game is categorized as playable and is described as the first on-chain FPS, with a focus on player versus player mechanics.

Changes

File Path Change Summary
apps/nextjs/content/games/octoguns.mdoc Added new metadata for "Octoguns" including name, ID, developer, genres, color, status, descriptions, links, and tokens. Longform description added detailing gameplay mechanics.

Poem

In a world where octopi roam,
Eight minds to battle, a digital home.
FPS thrills on the blockchain's wave,
With strategy and skill, the brave will save.
So hop on in, let the games begin,
Octoguns awaits, let the fun spin! 🐇🎮


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (2)
apps/nextjs/content/games/octoguns.mdoc (2)

8-8: Fix grammatical issues in descriptions

There are a few grammatical issues in the text:

-"The worlds first onchain FPS"
+"The world's first on-chain FPS"

-"Octoguns is a player versus player FPS where two players battle controlling eight mind controlled humans, battling in a turn based strategy to decimate your opponent"
+"Octoguns is a player-versus-player FPS where two players battle by controlling eight mind-controlled humans in a turn-based strategy to decimate their opponent."

Also applies to: 29-29, 49-49


33-34: Use consistent chain ID format

The chain IDs are using raw hexadecimal values. Consider using named constants or a more readable format for better maintainability.

-  - '0x534e5f4d41494e'
-  - '555'
+  - SN_MAIN
+  - SLOT_TESTNET
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6c9f0f3 and 615d315.

📒 Files selected for processing (1)
  • apps/nextjs/content/games/octoguns.mdoc (1 hunks)
🔇 Additional comments (1)
apps/nextjs/content/games/octoguns.mdoc (1)

18-18: Verify screenshot count

The screenshotLength is set to 4, but 5 screenshots are provided in the PR objectives.

Comment on lines +1 to +20
{
name: "Octoguns",
id: "Octoguns",
developer: Studios.RuneLabs,
genres: ["FPS", "Strategy", "PVP"],
color: "#292534",
status: "mainnet",
description: "The worlds first onchain FPS",
longform:
"Octoguns is a player versus player FPS where two players battle controlling eight mind controlled humans, battling in a turn based strategy to decimate your opponent.",
links: {
twitter: "https://x.com/octoguns_",
homepage: "https://play.octoguns.xyz/",
},
chains: [ChainId.SLOT_TESTNET, ChainId.SN_MAIN],
operatingSystems: ["Web Browser"],
tokens: [Tokens.LORDS],
screenshotLength: 4,
playable: true,
---
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Remove duplicate metadata structure

The file contains the same metadata in two different formats. This duplication makes maintenance difficult and could lead to inconsistencies. Consider keeping only the YAML frontmatter format (the second version) as it's more standard for .mdoc files.

Here are some inconsistencies between the two versions:

  • Developer name: Studios.RuneLabs vs Rune Labs
  • Color format: "#292534" vs 292534
  • Chain IDs: Different formats and representations

Also applies to: 21-48

Comment on lines +38 to +40
icon:
coverImage:
screenshots:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add the provided images to the documentation

Based on the PR objectives, you have several images to add. Here's how to include them:

-icon: 
+icon: /images/octoguns/OCTOGUNS-CIRCLE.png
-coverImage: 
+coverImage: /images/octoguns/COVER-OCTOGUNS-NEW-LIGHTS.png
-screenshots:
+screenshots:
+  - /images/octoguns/OCTOPUS-ILLUSTRATION-HOMEPAGE.png
+  - /images/octoguns/COVER-OCTOGUNS-DOK.png
+  - /images/octoguns/Concept-art-Arena-Lights.png
+  - /images/octoguns/Concept-art-Octopus-16-9.png
+  - /images/octoguns/BUILDINGS-OCTOUNS-CITY.png

Note: Ensure the images are saved in the appropriate directory and follow the project's naming conventions.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
icon:
coverImage:
screenshots:
icon: /images/octoguns/OCTOGUNS-CIRCLE.png
coverImage: /images/octoguns/COVER-OCTOGUNS-NEW-LIGHTS.png
screenshots:
- /images/octoguns/OCTOPUS-ILLUSTRATION-HOMEPAGE.png
- /images/octoguns/COVER-OCTOGUNS-DOK.png
- /images/octoguns/Concept-art-Arena-Lights.png
- /images/octoguns/Concept-art-Octopus-16-9.png
- /images/octoguns/BUILDINGS-OCTOUNS-CITY.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant