Skip to content

Commit

Permalink
couple minor bugfixes but worth a new tag
Browse files Browse the repository at this point in the history
  • Loading branch information
Lwangaman authored and Lwangaman committed Apr 2, 2020
1 parent c21e6aa commit cdf49c3
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 21 deletions.
4 changes: 2 additions & 2 deletions bibleget-io.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/*
* Plugin Name: BibleGet I/O
* Version: 5.1
* Version: 5.2
* Plugin URI: https://www.bibleget.io/
* Description: Easily insert Bible quotes from a choice of Bible versions into your articles or pages with the shortcode [bibleget].
* Author: John Romano D'Orazio
Expand Down Expand Up @@ -29,7 +29,7 @@

//TODO: better ui for the customizer, use sliders

define ( "BIBLEGETPLUGINVERSION", "v5_1" );
define ( "BIBLEGETPLUGINVERSION", "v5_2" );

if (! defined ( 'ABSPATH' )) {
header ( 'Status: 403 Forbidden' );
Expand Down
13 changes: 11 additions & 2 deletions css/admin.css
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,18 @@ form input[type=color] {
margin: 0px auto;
}

#biblegetio_reveal_server_variable {
cursor: pointer;
background-color: lightgray;
padding: 4px 6px;
display: inline-block;
}
#biblegetio_reveal_server_variable:hover {
background-color: white;
}
#biblegetio_hidden_server_variable {
visibility: hidden;
}
#biblegetio_reveal_server_variable:focus ~ #biblegetio_hidden_server_variable {
#biblegetio_reveal_server_variable:active ~ #biblegetio_hidden_server_variable {
visibility: visible;
}
}
26 changes: 13 additions & 13 deletions js/admin.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,19 +192,19 @@ jQuery(document).ready(function($) {

}
else{
console.log('We do not seem to have a gfontsPreviewJob');
console.log(typeof gfontsBatch);
console.log(gfontsBatch);
console.log('TEST CONDITION 1: typeof gfontsBatch !== \'undefined\'');
console.log(typeof gfontsBatch !== 'undefined');
console.log('TEST CONDITION 2: typeof gfontsBatch === \'object\'');
console.log(typeof gfontsBatch === 'object');
console.log('TEST CONDITION 3: gfontsBatch.hasOwnProperty(\'job\')');
console.log(gfontsBatch.hasOwnProperty('job'));
console.log('TEST CONDITION 4: gfontsBatch.job.hasOwnProperty(\'gfontsPreviewJob\')');
console.log(gfontsBatch.job.hasOwnProperty('job'));
console.log('TEST CONDITION 5: gfontsBatch.job.gfontsPreviewJob === true (an actual boolean value)');
console.log(gfontsBatch.job.gfontsPreviewJob === true);
// console.log('We do not seem to have a gfontsPreviewJob');
// console.log(typeof gfontsBatch);
// console.log(gfontsBatch);
// console.log('TEST CONDITION 1: typeof gfontsBatch !== \'undefined\'');
// console.log(typeof gfontsBatch !== 'undefined');
// console.log('TEST CONDITION 2: typeof gfontsBatch === \'object\'');
// console.log(typeof gfontsBatch === 'object');
// console.log('TEST CONDITION 3: gfontsBatch.hasOwnProperty(\'job\')');
// console.log(gfontsBatch.hasOwnProperty('job'));
// console.log('TEST CONDITION 4: gfontsBatch.job.hasOwnProperty(\'gfontsPreviewJob\')');
// console.log(gfontsBatch.job.hasOwnProperty('job'));
// console.log('TEST CONDITION 5: gfontsBatch.job.gfontsPreviewJob === true (an actual boolean value)');
// console.log(gfontsBatch.job.gfontsPreviewJob === true);
}


Expand Down
6 changes: 3 additions & 3 deletions options.php
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,9 @@ public function googlefontsapikey_callback(){
" " . __("Please note that this may have a little bit of an impact on the loading performance of your Wordpress Customizer.","bibleget-io") .
" " . __("If you notice that it becomes too sluggish, you had best leave this field empty.","bibleget-io") .
/* translators: please do not change the placeholders %s, they will be substituted dynamically by values in the script. See http://php.net/sprintf. */
"<br /> (" . sprintf(__("To see the value of the %s variable on your server %s Press here %s","bibleget-io"),"&#x24;&#x5F;SERVER&#x5B;&#x27;SERVER&#x5F;ADDR&#x27;&#x5D;","<button id=\"biblegetio_reveal_server_variable\">","</button>") .
"<span id=\"biblegetio_hidden_server_variable\">: [" . $_SERVER['SERVER_ADDR'] . "] )</span>" .
"</i>";
"<br /> (" . sprintf(__("To see the value of the %s variable on your server %s Press here %s","bibleget-io"),"&#x24;&#x5F;SERVER&#x5B;&#x27;SERVER&#x5F;ADDR&#x27;&#x5D;","<span id=\"biblegetio_reveal_server_variable\" tabindex=\"0\">","</span>") .
"<span id=\"biblegetio_hidden_server_variable\"> [" . $_SERVER['SERVER_ADDR'] . "] )</span>" .
"</i>";
}

public function gfontsAPIkeyCheck(){
Expand Down
9 changes: 8 additions & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Donate link: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_i
Tags: bible,shortcode,quote,citation,verses
Requires at least: 3.3
Tested up to: 5.4
Stable tag: 5.1
Stable tag: 5.2
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -111,6 +111,10 @@ and become available in the customizer interface for the BibleGet plugin.

== Changelog ==

= 5.2 =
* Small bugfix where a stray javascript debugging line was throwing an error
* Small fix to new html elements and their styling on the page

= 5.1 =
* verified compatibility with Wordpress 5.4
* Bugfix: uninstall was not taking into account the newer ajax requests and could have prevented the plugin from being uninstalled
Expand Down Expand Up @@ -262,6 +266,9 @@ and become available in the customizer interface for the BibleGet plugin.

== Upgrade Notice ==

= 5.2 =
Versions prior to 3.6 must be updated. v5.2 verifies compatibility with Wordpress 5.4 and fixes a bug that was preventing a correct uninstallation of the plugin

= 5.1 =
Versions prior to 3.6 must be updated. v5.1 verifies compatibility with Wordpress 5.4 and fixes a bug that was preventing a correct uninstallation of the plugin

Expand Down

0 comments on commit cdf49c3

Please sign in to comment.