-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpin numpy version #345
unpin numpy version #345
Conversation
changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Thanks for the fix! It would be great if this can get merged and release soon. |
Hi guys! Just two questions to this. Could this enable numpy > 2.0 to be installed along with the plugin? If so, have you tested the plugin with it? I am asking because numpy >2.0 brings many changes and some things may not work anymore, and the changes above wouldn't restrain it unless some other dependency does. |
fwiw the CI tests for 43f5f82 was done with numpy>2:
Edit: I also tested the plotting widget manually with numpy==2.0.2. |
I also just tested all the plotting, dimensionality reduction and clustering functions from the GUI and couldn't spot anything when numpy 2.0 is used. I tested with surface, point, 3D tracking and 2D time-lapse data. If you don't have any other concerns @zoccoler I will just merge this and then we can release the new version? |
Awesome! Then please feel free to merge @Cryaaa ! |
Changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr. Thanks to @ziw-liu for bringing it up. Once merged this will close issue #215. I know this will be fixed anyway in v 0.9.0 but it might be good to fix it in this release in case the new version has some backwards compatibility breaking changes.