Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin numpy version #345

Merged
merged 1 commit into from
Oct 25, 2024
Merged

unpin numpy version #345

merged 1 commit into from
Oct 25, 2024

Conversation

Cryaaa
Copy link
Collaborator

@Cryaaa Cryaaa commented Sep 17, 2024

Changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr. Thanks to @ziw-liu for bringing it up. Once merged this will close issue #215. I know this will be fixed anyway in v 0.9.0 but it might be good to fix it in this release in case the new version has some backwards compatibility breaking changes.

changed the dependencies to not rely on pinned numpy versions which are no longer supported by libraries like zarr
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.47%. Comparing base (c7bae7b) to head (43f5f82).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   79.47%   79.47%           
=======================================
  Files          16       16           
  Lines        2076     2076           
=======================================
  Hits         1650     1650           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziw-liu
Copy link

ziw-liu commented Oct 16, 2024

Thanks for the fix! It would be great if this can get merged and release soon.

@zoccoler
Copy link
Collaborator

Hi guys!

Just two questions to this. Could this enable numpy > 2.0 to be installed along with the plugin? If so, have you tested the plugin with it?

I am asking because numpy >2.0 brings many changes and some things may not work anymore, and the changes above wouldn't restrain it unless some other dependency does.

@ziw-liu
Copy link

ziw-liu commented Oct 21, 2024

fwiw the CI tests for 43f5f82 was done with numpy>2:

numpy-2.0.2                |   py39h9cb892a_0         7.4 MB  conda-forge

Edit: I also tested the plotting widget manually with numpy==2.0.2.

@Cryaaa
Copy link
Collaborator Author

Cryaaa commented Oct 22, 2024

I also just tested all the plotting, dimensionality reduction and clustering functions from the GUI and couldn't spot anything when numpy 2.0 is used. I tested with surface, point, 3D tracking and 2D time-lapse data. If you don't have any other concerns @zoccoler I will just merge this and then we can release the new version?

@zoccoler
Copy link
Collaborator

Awesome! Then please feel free to merge @Cryaaa !

@Cryaaa Cryaaa merged commit 4cbb725 into main Oct 25, 2024
8 checks passed
@Cryaaa Cryaaa deleted the unpin_numpy_version branch October 25, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants