Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zooming problem #298

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix zooming problem #298

merged 2 commits into from
Jan 19, 2024

Conversation

thorstenwagner
Copy link
Collaborator

Fix issue #297

Now it works in both cases: The one I described in #294 and the other one described in #254

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (eca8459) 77.30% compared to head (bf031be) 77.22%.
Report is 9 commits behind head on main.

Files Patch % Lines
napari_clusters_plotter/_Qt_code.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   77.30%   77.22%   -0.09%     
==========================================
  Files          16       16              
  Lines        1899     1901       +2     
==========================================
  Hits         1468     1468              
- Misses        431      433       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thorstenwagner thorstenwagner mentioned this pull request Jan 18, 2024
@thorstenwagner thorstenwagner linked an issue Jan 19, 2024 that may be closed by this pull request
@Cryaaa
Copy link
Collaborator

Cryaaa commented Jan 19, 2024

I don't see anything wrong with the code changes suggested, and since you've tested it I will merge and then test the final release version!

@Cryaaa Cryaaa merged commit 5e937dc into main Jan 19, 2024
8 checks passed
@Cryaaa Cryaaa deleted the fix-zoom-2 branch January 23, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom is reset after selection of cluster
2 participants