-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update method generate_cluster_tracks() #290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefanhahmann
commented
Dec 18, 2023
•
edited
Loading
edited
- In Fix Tracking Layer #286 (comment) it was pointed out that
- This PR is dedicated to provide a solution for this:
- Cluster tracks generates now image specific label and cluster id lists instead of repeating the complete lists containing all labels for all images
- Generate_cluster_image() does not need to account for that fact anymore
* Cluster tracks generates now image specific label and cluster id lists instead of repeating the complete lists containing all labels for all images * generate_cluster_image() does not need to account for that fact anymore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
+ Coverage 77.17% 77.32% +0.14%
==========================================
Files 16 16
Lines 1893 1896 +3
==========================================
+ Hits 1461 1466 +5
+ Misses 432 430 -2 ☔ View full report in Codecov by Sentry. |
stefanhahmann
force-pushed
the
change_generate_cluster_tracks
branch
from
December 18, 2023 11:53
16b07dd
to
93eb33d
Compare
Cryaaa
reviewed
Dec 18, 2023
…ue label ids per image
Added comments to indicate why we do it this way.
for more information, see https://pre-commit.ci
I think, this PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.