Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method generate_cluster_tracks() #290

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Conversation

stefanhahmann
Copy link
Contributor

@stefanhahmann stefanhahmann commented Dec 18, 2023

The problem is that my method assumes that label_list only contains labels that are actually part of the label_image, which is not the case for your track data. I think it should, and the implementation of generate_cluster_tracks may be buggy as it produces the same label_list for each time point, regardless of the actual labels at that time point.

  • This PR is dedicated to provide a solution for this:
    • Cluster tracks generates now image specific label and cluster id lists instead of repeating the complete lists containing all labels for all images
    • Generate_cluster_image() does not need to account for that fact anymore

* Cluster tracks generates now image specific label and cluster id lists instead of repeating the complete lists containing all labels for all images
* generate_cluster_image() does not need to account for that fact anymore
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e195b69) 77.17% compared to head (f736d3b) 77.32%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   77.17%   77.32%   +0.14%     
==========================================
  Files          16       16              
  Lines        1893     1896       +3     
==========================================
+ Hits         1461     1466       +5     
+ Misses        432      430       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanhahmann
Copy link
Contributor Author

I think, this PR is ready to be merged.

@Cryaaa Cryaaa merged commit db9aea7 into main Dec 20, 2023
8 checks passed
@stefanhahmann stefanhahmann deleted the change_generate_cluster_tracks branch December 20, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants