Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert max label to integer before using it as parameter for np.zeros #284

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

stefanhahmann
Copy link
Contributor

This PR fixes a the following exception:

grafik

which was raised after this workflow:

GIF 11 12 2023 15-23-57

The consequence of the exception was that no cluster_ids_in_space layer was generated after making a freehand selection in the clusters plotter.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a5286e) 76.39% compared to head (2efe878) 76.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files          16       16           
  Lines        1860     1860           
=======================================
  Hits         1421     1421           
  Misses        439      439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Dec 11, 2023

@stefanhahmann,
Thanks for catching this! Slightly weird that the label image is not stored as an integer array but possibly the numpy max function returns non integers by default..

@Cryaaa Cryaaa merged commit a7486c5 into main Dec 11, 2023
8 checks passed
@Cryaaa Cryaaa deleted the fix_generate_cluster_image branch January 23, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants