Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix opacity adjustment and set it to low non-zero value #280

Merged
merged 2 commits into from
Jan 15, 2024
Merged

fix opacity adjustment and set it to low non-zero value #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42125b
fix opacity adjustement and set it to low non-zero value
zoccoler Dec 6, 2023
d74d308
increase opacity a bit more
zoccoler Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napari_clusters_plotter/_plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
plot_cluster_name=clustering_ID,
)
if isinstance(self.analysed_layer, Labels):
self.layer_select.value.opacity = 0
self.layer_select.opacity = 0.2

Check warning on line 127 in napari_clusters_plotter/_plotter.py

View check run for this annotation

Codecov / codecov/patch

napari_clusters_plotter/_plotter.py#L127 

Added line #L127 was not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a bit. I would prefer 0.25 or even 0.3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to not increase it too much so maybe we can stick to 0.25, so that the experience does not change too dramatically?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.25 would be fine for. (I could also live with 0.2). The slight increase was just a subjective suggestion.


# Canvas Widget that displays the 'figure', it takes the 'figure' instance
self.graphics_widget = MplCanvas(
Expand Down
Loading